Skip to content

ROX-25540: Update Helm charts#12608

Merged
mclasmeier merged 4 commits intomasterfrom
mm/ROX-25540-helm
Sep 9, 2024
Merged

ROX-25540: Update Helm charts#12608
mclasmeier merged 4 commits intomasterfrom
mm/ROX-25540-helm

Conversation

@Maddosaurus
Copy link
Copy Markdown
Contributor

@Maddosaurus Maddosaurus commented Sep 4, 2024 •
edited
Loading

Description

For Node Indexing to work on the compliance container, some changes to the Helm chart are needed.
Namely, we are mounting a small part of the Node filesystem as read only, and set the fitting environment variables.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Used the updated Helm chart to deploy, then manually changed the images to the ones from #12448, which contain the new code.
Used the updated Helm chart to deploy to OpenShift 4 and to a GKE cluster. On the GKE cluster I verified that the deployment is functional and does not contain any of the settings needed for Node Indexing.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Sep 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Sep 4, 2024 •
edited
Loading

Images are ready for the commit at 8863173.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-446-g8863173c42.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.27%. Comparing base (bfc1ad7) to head (f805762).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12608      +/-   ##
==========================================
- Coverage   48.27%   48.27%   -0.01%     
==========================================
  Files        2422     2422              
  Lines      172783   172783              
==========================================
- Hits        83415    83413       -2     
- Misses      82630    82631       +1     
- Partials     6738     6739       +1
Flag Coverage Δ
go-unit-tests 48.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maddosaurus Maddosaurus marked this pull request as ready for review September 5, 2024 09:13
@Maddosaurus Maddosaurus requested review from a team and mclasmeier September 5, 2024 09:13
mclasmeier
mclasmeier requested changes Sep 5, 2024
View reviewed changes
@Maddosaurus
Address review comments
d9b8c21 
- Whitespace trimming
- Formatting
- Condition update
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Sep 6, 2024 •
edited
Loading

@Maddosaurus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-16-qa-e2e-tests 8863173 link false /test ocp-4-16-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Maddosaurus Maddosaurus added the pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted label Sep 6, 2024
@Maddosaurus
Copy link
Copy Markdown
Contributor Author

Maddosaurus commented Sep 6, 2024

If everyone is okay with the changes, please merge this PR if possible.

@mclasmeier mclasmeier merged commit d229db3 into master Sep 9, 2024
@mclasmeier mclasmeier deleted the mm/ROX-25540-helm branch September 9, 2024 06:44
@lvalerom lvalerom mentioned this pull request Sep 11, 2024
Merged
9 tasks
acravn pushed a commit to acravn/stackrox that referenced this pull request Sep 20, 2024
@Maddosaurus
ROX-25540: Update Helm charts (stackrox#12608)
2f1dbbf 
Extend Helm chart to support node indexing in the compliance container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mclasmeier mclasmeier mclasmeier approved these changes

Assignees

No one assigned

Labels

area/helm pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted team/maple

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maddosaurus @rhacs-bot @mclasmeier