Skip to content

chore: bump hashicorp/go-retryablehttp to v0.7.7#11755

Closed
gavin-stackrox wants to merge 2 commits into
release-4.4from
gavin/fix-GO-2024-2947
Closed

chore: bump hashicorp/go-retryablehttp to v0.7.7#11755
gavin-stackrox wants to merge 2 commits into
release-4.4from
gavin/fix-GO-2024-2947

Conversation

@gavin-stackrox

@gavin-stackrox gavin-stackrox commented Jun 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

To avoid triggering https://pkg.gop.dev/vuln/GO-2024-2947.

User-facing documentation

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • contributed no automated tests

How I validated my change

CI

@openshift-ci

openshift-ci Bot commented Jun 27, 2024

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gavin-stackrox gavin-stackrox changed the base branch from master to release-4.4 June 27, 2024 21:23
@gavin-stackrox gavin-stackrox added the scan-go-binaries Run the scan-go-binaries step on PRs label Jun 27, 2024
@gavin-stackrox

gavin-stackrox commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

/test all

@gavin-stackrox gavin-stackrox marked this pull request as ready for review June 27, 2024 21:31
@github-actions github-actions Bot added the backport PR to backport changes from master to release branch label Jun 27, 2024
@rhacs-bot

rhacs-bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 3caf1f4.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.4-rc.2-2-g3caf1f4e40.

@gavin-stackrox

gavin-stackrox commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

/test ?

@openshift-ci

openshift-ci Bot commented Jun 27, 2024

Copy link
Copy Markdown

@gavin-stackrox: The following commands are available to trigger required jobs:

  • /test shell-unit-tests

The following commands are available to trigger optional jobs:

  • /test aro-qa-e2e-tests
  • /test eks-ebpf-qa-e2e-tests
  • /test eks-qa-e2e-tests
  • /test gke-nongroovy-e2e-tests
  • /test gke-operator-e2e-tests
  • /test gke-qa-e2e-tests
  • /test gke-race-condition-qa-e2e-tests
  • /test gke-scale-tests
  • /test gke-scanner-v4-tests
  • /test gke-sensor-integration-tests
  • /test gke-ui-e2e-tests
  • /test gke-upgrade-tests
  • /test gke-version-compatibility-tests
  • /test ocp-4-11-compliance-e2e-tests
  • /test ocp-4-11-ebpf-qa-e2e-tests
  • /test ocp-4-11-operator-e2e-tests
  • /test ocp-4-11-qa-e2e-tests
  • /test ocp-4-11-scanner-v4-tests
  • /test ocp-4-11-sensor-integration-tests
  • /test ocp-4-11-ui-e2e-tests
  • /test ocp-4-15-compliance-e2e-tests
  • /test ocp-4-15-ebpf-qa-e2e-tests
  • /test ocp-4-15-fips-qa-e2e-tests
  • /test ocp-4-15-operator-e2e-tests
  • /test ocp-4-15-qa-e2e-tests
  • /test ocp-4-15-scanner-v4-tests
  • /test ocp-4-15-sensor-integration-tests
  • /test ocp-4-15-ui-e2e-tests
  • /test osd-gcp-qa-e2e-tests
  • /test powervs-qa-e2e-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-stackrox-stackrox-release-4.4-gke-nongroovy-e2e-tests
  • pull-ci-stackrox-stackrox-release-4.4-gke-qa-e2e-tests
  • pull-ci-stackrox-stackrox-release-4.4-gke-sensor-integration-tests
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gavin-stackrox

gavin-stackrox commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

/test ocp-4-15-qa-e2e-tests
/test ocp-4-11-operator-e2e-tests

@codecov

codecov Bot commented Jun 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (0f4b76f) to head (6b4fc42).

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-4.4   #11755   +/-   ##
============================================
  Coverage        47.77%   47.77%           
============================================
  Files             2503     2503           
  Lines           170960   170960           
============================================
  Hits             81668    81668           
  Misses           82574    82574           
  Partials          6718     6718
Flag Coverage Δ
go-unit-tests 47.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavin-stackrox gavin-stackrox added the auto-retest PRs with this label will be automatically retested if prow checks fails label Jun 28, 2024
@rhacs-bot

rhacs-bot commented Jun 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 6b4fc42.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.4-2-g6b4fc42171.

@gavin-stackrox gavin-stackrox force-pushed the gavin/fix-GO-2024-2947 branch from 3caf1f4 to 6b4fc42 Compare July 3, 2024 16:23
@gavin-stackrox

gavin-stackrox commented Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

closing in favor of #11385

@gavin-stackrox gavin-stackrox deleted the gavin/fix-GO-2024-2947 branch July 3, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-retest PRs with this label will be automatically retested if prow checks fails backport PR to backport changes from master to release branch scan-go-binaries Run the scan-go-binaries step on PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gavin-stackrox @rhacs-bot