Skip to content

fix(CI): temporarily disable ECR tests#10688

Closed
gavin-stackrox wants to merge 2 commits into
release-4.4from
gavin/disable-AWS
Closed

fix(CI): temporarily disable ECR tests#10688
gavin-stackrox wants to merge 2 commits into
release-4.4from
gavin/disable-AWS

Conversation

@gavin-stackrox

@gavin-stackrox gavin-stackrox commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Description

Per title.

Checklist

  • Investigated and inspected CI test results

Testing Performed

Here I tell how I validated my change

CI is sufficient.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@gavin-stackrox gavin-stackrox requested a review from a team as a code owner April 9, 2024 18:21
@gavin-stackrox gavin-stackrox requested a review from a team April 9, 2024 18:21
@gavin-stackrox gavin-stackrox requested review from a team as code owners April 9, 2024 18:21
@gavin-stackrox gavin-stackrox changed the base branch from master to release-4.4 April 9, 2024 18:21
@gavin-stackrox gavin-stackrox removed request for a team April 9, 2024 18:22

@davdhacs davdhacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot added the backport PR to backport changes from master to release branch label Apr 9, 2024
@rhacs-bot

Copy link
Copy Markdown
Contributor

Images are ready for the commit at bf1811c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.1-rc.1-3-gbf1811c586.

@codecov

codecov Bot commented Apr 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.70%. Comparing base (4c29fd1) to head (bf1811c).
Report is 1 commits behind head on release-4.4.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-4.4   #10688   +/-   ##
============================================
  Coverage        47.70%   47.70%           
============================================
  Files             2499     2499           
  Lines           170494   170494           
============================================
  Hits             81335    81335           
  Misses           82469    82469           
  Partials          6690     6690           
Flag Coverage Δ
go-unit-tests 47.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavin-stackrox

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Apr 10, 2024

Copy link
Copy Markdown

@gavin-stackrox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests bf1811c link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gavin-stackrox gavin-stackrox deleted the gavin/disable-AWS branch April 10, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants