Skip to content

chore(deps): Bump protobuf version#10270

Merged
c-du merged 1 commit into
masterfrom
cong/protobump
Mar 7, 2024
Merged

chore(deps): Bump protobuf version#10270
c-du merged 1 commit into
masterfrom
cong/protobump

Conversation

@c-du

@c-du c-du commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Description

Pickup the fix for GO-2024-2611(CVE-2024-24786)

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added

If any of these don't apply, please comment below.

Testing Performed

Existing tests

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@c-du c-du requested review from RTann, dhaus67 and janisz March 7, 2024 19:49
@c-du

c-du commented Mar 7, 2024

Copy link
Copy Markdown
Contributor Author

/test

@openshift-ci

openshift-ci Bot commented Mar 7, 2024

Copy link
Copy Markdown

@c-du: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test shell-unit-tests

The following commands are available to trigger optional jobs:

  • /test aks-qa-e2e-tests
  • /test aro-qa-e2e-tests
  • /test eks-qa-e2e-tests
  • /test gke-nongroovy-e2e-tests
  • /test gke-operator-e2e-tests
  • /test gke-perf-scale-tests
  • /test gke-qa-e2e-tests
  • /test gke-race-condition-qa-e2e-tests
  • /test gke-scale-tests
  • /test gke-scanner-v4-tests
  • /test gke-sensor-integration-tests
  • /test gke-ui-e2e-tests
  • /test gke-upgrade-tests
  • /test gke-version-compatibility-tests
  • /test ibmcloudz-4-13-qa-e2e-tests
  • /test ibmcloudz-4-14-qa-e2e-tests
  • /test ocp-4-11-compliance-e2e-tests
  • /test ocp-4-11-ebpf-qa-e2e-tests
  • /test ocp-4-11-operator-e2e-tests
  • /test ocp-4-11-qa-e2e-tests
  • /test ocp-4-11-scanner-v4-tests
  • /test ocp-4-11-sensor-integration-tests
  • /test ocp-4-11-sensor-profiling
  • /test ocp-4-11-ui-e2e-tests
  • /test ocp-4-14-compliance-e2e-tests
  • /test ocp-4-14-ebpf-qa-e2e-tests
  • /test ocp-4-14-fips-qa-e2e-tests
  • /test ocp-4-14-operator-e2e-tests
  • /test ocp-4-14-perf-scale-tests
  • /test ocp-4-14-qa-e2e-tests
  • /test ocp-4-14-scanner-v4-tests
  • /test ocp-4-14-sensor-integration-tests
  • /test ocp-4-14-sensor-profiling
  • /test ocp-4-14-ui-e2e-tests
  • /test ocp-4-15-compliance-e2e-tests
  • /test ocp-4-15-ebpf-qa-e2e-tests
  • /test ocp-4-15-fips-qa-e2e-tests
  • /test ocp-4-15-operator-e2e-tests
  • /test ocp-4-15-qa-e2e-tests
  • /test ocp-4-15-scanner-v4-tests
  • /test ocp-4-15-sensor-integration-tests
  • /test ocp-4-15-sensor-profiling
  • /test ocp-4-15-ui-e2e-tests
  • /test ocp-stable-scanner-v4-compliance-e2e-tests
  • /test ocp-stable-scanner-v4-ebpf-qa-e2e-tests
  • /test ocp-stable-scanner-v4-operator-e2e-tests
  • /test ocp-stable-scanner-v4-perf-scale-tests
  • /test ocp-stable-scanner-v4-qa-e2e-tests
  • /test ocp-stable-scanner-v4-scanner-v4-tests
  • /test ocp-stable-scanner-v4-sensor-integration-tests
  • /test ocp-stable-scanner-v4-sensor-profiling
  • /test ocp-stable-scanner-v4-ui-e2e-tests
  • /test osd-aws-qa-e2e-tests
  • /test osd-gcp-qa-e2e-tests
  • /test powervs-4-12-qa-corebpf-e2e-tests
  • /test powervs-4-12-qa-ebpf-e2e-tests
  • /test powervs-4-13-qa-corebpf-e2e-tests
  • /test powervs-4-13-qa-ebpf-e2e-tests
  • /test powervs-4-15-qa-corebpf-e2e-tests
  • /test powervs-4-15-qa-ebpf-e2e-tests
  • /test powervs-qa-corebpf-e2e-tests
  • /test powervs-qa-ebpf-e2e-tests
  • /test rosa-hcp-qa-e2e-tests
  • /test rosa-qa-e2e-tests
  • /test ui-component-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-sensor-integration-tests
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c-du c-du changed the title chore(protobuf): Bump protobuf version chore(deps): Bump protobuf version Mar 7, 2024
@rhacs-bot

Copy link
Copy Markdown
Contributor

Images are ready for the commit at da70fce.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-84-gda70fce604.

@codecov

codecov Bot commented Mar 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.96%. Comparing base (05d9f4e) to head (da70fce).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10270   +/-   ##
=======================================
  Coverage   47.96%   47.96%           
=======================================
  Files        2420     2420           
  Lines      169393   169393           
=======================================
+ Hits        81247    81253    +6     
+ Misses      81461    81457    -4     
+ Partials     6685     6683    -2     
Flag Coverage Δ
go-unit-tests 47.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-du c-du merged commit 6c4b0d3 into master Mar 7, 2024
@c-du c-du deleted the cong/protobump branch March 7, 2024 21:51
@c-du c-du added this to the 4.4.0-rc.5 milestone Mar 7, 2024
@stehessel stehessel mentioned this pull request Mar 7, 2024
5 tasks
@github-actions

github-actions Bot commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Merge commit has been cherry-picked to branch release-4.4.

rhacs-bot pushed a commit that referenced this pull request Mar 8, 2024
dcaravel pushed a commit that referenced this pull request May 15, 2024
davdhacs added a commit that referenced this pull request Mar 2, 2026
io.cri-containerd.pinned has known bugs (containerd#9328, #10270)
that make it unreliable for preventing image GC.

Replace the pinning approach with a re-pull step: after the prefetcher
completes, run ctr images pull on each node for any images whose tag
reference was lost to GC. Since layers are still cached, re-pulls are
near-instant. Uses the same image list configmap as the prefetcher.

Only re-pulls images that are missing (ctr images check); skips images
that are still present.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
davdhacs added a commit that referenced this pull request Mar 2, 2026
io.cri-containerd.pinned has known bugs (containerd#9328, #10270)
that make it unreliable for preventing image GC.

Replace the pinning approach with a re-pull step: after the prefetcher
completes, run ctr images pull on each node for any images whose tag
reference was lost to GC. Since layers are still cached, re-pulls are
near-instant. Uses the same image list configmap as the prefetcher.

Only re-pulls images that are missing (ctr images check); skips images
that are still present.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
davdhacs added a commit that referenced this pull request Mar 2, 2026
io.cri-containerd.pinned has known bugs (containerd#9328, #10270)
that make it unreliable for preventing image GC.

Replace the pinning approach with a re-pull step: after the prefetcher
completes, run ctr images pull on each node for any images whose tag
reference was lost to GC. Since layers are still cached, re-pulls are
near-instant. Uses the same image list configmap as the prefetcher.

Only re-pulls images that are missing (ctr images check); skips images
that are still present.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
davdhacs added a commit that referenced this pull request Mar 2, 2026
io.cri-containerd.pinned has known bugs (containerd#9328, #10270)
that make it unreliable for preventing image GC.

Replace the pinning approach with a re-pull step: after the prefetcher
completes, run ctr images pull on each node for any images whose tag
reference was lost to GC. Since layers are still cached, re-pulls are
near-instant. Uses the same image list configmap as the prefetcher.

Only re-pulls images that are missing (ctr images check); skips images
that are still present.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
davdhacs added a commit that referenced this pull request Mar 2, 2026
io.cri-containerd.pinned has known bugs (containerd#9328, #10270)
that make it unreliable for preventing image GC.

Replace the pinning approach with a re-pull step: after the prefetcher
completes, run ctr images pull on each node for any images whose tag
reference was lost to GC. Since layers are still cached, re-pulls are
near-instant. Uses the same image list configmap as the prefetcher.

Only re-pulls images that are missing (ctr images check); skips images
that are still present.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants