Skip to content

ROX-22912: bump google protobuf#10261

Closed
stehessel wants to merge 1 commit into
masterfrom
ROX-22912/bump-google-protobuf
Closed

ROX-22912: bump google protobuf#10261
stehessel wants to merge 1 commit into
masterfrom
ROX-22912/bump-google-protobuf

Conversation

@stehessel

@stehessel stehessel commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator

Description

This should fix GO-2024-2611, which has been found by our go-scan-binaries CI job. See https://pkg.go.dev/vuln/GO-2024-2611 for more info.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

go scan test passes

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@stehessel stehessel requested a review from janisz March 6, 2024 23:33
@stehessel stehessel mentioned this pull request Mar 6, 2024
Closed
5 tasks
@stehessel stehessel force-pushed the ROX-22912/bump-google-protobuf branch from 839478e to 89fc301 Compare March 7, 2024 00:15
@rhacs-bot

rhacs-bot commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 89fc301.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-74-g89fc301960.

@stehessel

stehessel commented Mar 7, 2024

Copy link
Copy Markdown
Collaborator Author

/test go-scan-binaries

@openshift-ci

openshift-ci Bot commented Mar 7, 2024

Copy link
Copy Markdown

@stehessel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test shell-unit-tests

The following commands are available to trigger optional jobs:

  • /test aks-qa-e2e-tests
  • /test aro-qa-e2e-tests
  • /test eks-qa-e2e-tests
  • /test gke-nongroovy-e2e-tests
  • /test gke-operator-e2e-tests
  • /test gke-perf-scale-tests
  • /test gke-qa-e2e-tests
  • /test gke-race-condition-qa-e2e-tests
  • /test gke-scale-tests
  • /test gke-scanner-v4-tests
  • /test gke-sensor-integration-tests
  • /test gke-ui-e2e-tests
  • /test gke-upgrade-tests
  • /test gke-version-compatibility-tests
  • /test ibmcloudz-4-13-qa-e2e-tests
  • /test ibmcloudz-4-14-qa-e2e-tests
  • /test ocp-4-11-compliance-e2e-tests
  • /test ocp-4-11-ebpf-qa-e2e-tests
  • /test ocp-4-11-operator-e2e-tests
  • /test ocp-4-11-qa-e2e-tests
  • /test ocp-4-11-scanner-v4-tests
  • /test ocp-4-11-sensor-integration-tests
  • /test ocp-4-11-sensor-profiling
  • /test ocp-4-11-ui-e2e-tests
  • /test ocp-4-14-compliance-e2e-tests
  • /test ocp-4-14-ebpf-qa-e2e-tests
  • /test ocp-4-14-fips-qa-e2e-tests
  • /test ocp-4-14-operator-e2e-tests
  • /test ocp-4-14-perf-scale-tests
  • /test ocp-4-14-qa-e2e-tests
  • /test ocp-4-14-scanner-v4-tests
  • /test ocp-4-14-sensor-integration-tests
  • /test ocp-4-14-sensor-profiling
  • /test ocp-4-14-ui-e2e-tests
  • /test ocp-4-15-compliance-e2e-tests
  • /test ocp-4-15-ebpf-qa-e2e-tests
  • /test ocp-4-15-fips-qa-e2e-tests
  • /test ocp-4-15-operator-e2e-tests
  • /test ocp-4-15-qa-e2e-tests
  • /test ocp-4-15-scanner-v4-tests
  • /test ocp-4-15-sensor-integration-tests
  • /test ocp-4-15-sensor-profiling
  • /test ocp-4-15-ui-e2e-tests
  • /test ocp-stable-scanner-v4-compliance-e2e-tests
  • /test ocp-stable-scanner-v4-ebpf-qa-e2e-tests
  • /test ocp-stable-scanner-v4-operator-e2e-tests
  • /test ocp-stable-scanner-v4-perf-scale-tests
  • /test ocp-stable-scanner-v4-qa-e2e-tests
  • /test ocp-stable-scanner-v4-scanner-v4-tests
  • /test ocp-stable-scanner-v4-sensor-integration-tests
  • /test ocp-stable-scanner-v4-sensor-profiling
  • /test ocp-stable-scanner-v4-ui-e2e-tests
  • /test osd-aws-qa-e2e-tests
  • /test osd-gcp-qa-e2e-tests
  • /test powervs-4-12-qa-corebpf-e2e-tests
  • /test powervs-4-12-qa-ebpf-e2e-tests
  • /test powervs-4-13-qa-corebpf-e2e-tests
  • /test powervs-4-13-qa-ebpf-e2e-tests
  • /test powervs-4-15-qa-corebpf-e2e-tests
  • /test powervs-4-15-qa-ebpf-e2e-tests
  • /test powervs-qa-corebpf-e2e-tests
  • /test powervs-qa-ebpf-e2e-tests
  • /test rosa-hcp-qa-e2e-tests
  • /test rosa-qa-e2e-tests
  • /test ui-component-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-scanner-v4-tests
  • pull-ci-stackrox-stackrox-master-gke-sensor-integration-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-11-scanner-v4-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-14-scanner-v4-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-15-scanner-v4-tests
Details

In response to this:

/test go-scan-binaries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gavin-stackrox

gavin-stackrox commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

I think this line needs to be removed so go-scan-binaries runs on PRs:

stackrox/.github/workflows/build.yaml

Line 575 in 20e00fb

if: github.event_name == 'push'

@janisz

janisz commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown

@stehessel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-scanner-v4-tests 89fc301 link false /test gke-scanner-v4-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stehessel

stehessel commented Mar 7, 2024

Copy link
Copy Markdown
Collaborator Author

duplicated by #10270

@stehessel stehessel closed this Mar 7, 2024
@stehessel stehessel deleted the ROX-22912/bump-google-protobuf branch September 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stehessel @rhacs-bot @gavin-stackrox @janisz