Closed
Conversation
…ing custom status through extensions (#17)
Fix log format string interpolation
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
…rs (#42) * Add filter predicate to secret kind watch * Change fix to filter resource in the reconcile function * Fix doc string typo * Update description for setting broken action client
12 tasks
Contributor
|
I don't understand what the screenshot you attached is showing. What I see if I check out this branch is the following, which seems ok to me:
|
vladbologa
approved these changes
Sep 16, 2024
Contributor
vladbologa
left a comment
vladbologa
left a comment
There was a problem hiding this comment.
LGTM, but in the meantime there's another commit in helm-operator-plugins which you might want to include.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents the changes in #44 but rebased against recent upstream.
Importantly, at this point upstream already contains the merge commit for operator-framework/helm-operator-plugins#380
This PR is just for easy review. the goal is not to merge this, but to re-set the fork's
mainbranch to tip of this branch after the rebase is reviewed.This is tested in stackrox/stackrox#12614