Skip to content

fix-nullable-json-comparison-filtering - #934

Merged
jeffreyaven merged 1 commit into
mainfrom
nullable-comparison-robot-coverage
Nov 18, 2026
Merged

jeffreyaven merged 1 commit into
mainfrom
nullable-comparison-robot-coverage

Conversation

@jeffreyaven

@jeffreyaven jeffreyaven commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Post-merge follow-up to #933. The contributor's original commits are now on main. Their latest commit already addressed the Copilot review's driver-level tests and both-NULL vectors.

The additional black-box Robot regression exposed a second implementation: WHERE evaluation uses OmniSDK and still aborted on missing properties with fn: json_equal: Invalid JSON strings. Pin the minimal upstream fix from stackql-labs/omnisdk#60. That PR must merge before this one.

Cover both functions with left-missing, right-missing, both-missing, matching, mismatching and JSON-null-containing optional properties. Assert every projected row and the exact filtered IDs. SQL-generated JSON fixtures avoid platform-specific shell quoting. Correct the divergence documentation: NULL propagation intentionally differs from the retired C implementation.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

Evidence

Commands run from repository root in PowerShell, with CGO_ENABLED=0 for Go commands and PYTHONPATH pointing to test\python for Robot:

  • go mod tidy: passed, no unrelated dependency changes.
  • go test -timeout 120s .\internal\stackql\sqlengine .\internal\stackql\sqlengine\internal\sqlfuncs .\internal\stackql\intrinsic: SQL engine and function packages passed; intrinsic failed in five pre-existing symlink-based fixtures because this Windows account lacks symlink privileges.
  • go build -o .\build\stackql-null-914.exe .\stackql: passed using the downloaded immutable OmniSDK revision, without a local replace or Go workspace.
  • python -m robot --outputdir C:\Users\javen\.copilot\session-state\183dee7b-9388-4f47-80eb-4f3dcc332eb3\files\robot-null-914 --variable "STACKQL_EXE:C:\LocalGitRepos\stackql\core\stackql\build\stackql-null-914.exe" --test "Sqlite Nullable Optional Property Comparisons Working" --test "Sqlite Extension Functions Smoke Working" test\robot\functional\stackql_mocked_from_cmd_line.robot: passed, 2 tests. The new regression failed before the OmniSDK bump because WHERE evaluation stopped after ID 1 instead of returning IDs 1 and 5.
  • .\build\tools\golangci-v2.15\golangci-lint.exe run --timeout 5m: passed, 0 issues with the CI-pinned linter.
  • git diff --check: passed.

CI evidence: gh pr checks 934 --repo stackql/stackql passed. Build run 44203099271, lint run 44203099146, MCP run 44203099169 and CodeQL run 44203093135 all completed successfully. Upstream PR and merged-main CI also passed.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

Local validation was focused on the changed behavior and the existing extension smoke test, not the entire Robot suite. SQL-engine unit tests pass; the broader intrinsic package is blocked locally by Windows symlink privileges. Full unit, Robot, platform and MCP checks passed in CI. Workflow-level runs were also audited, including runs that produce no PR check runs. An administrator merge is used only for the missing external approval on this maintainer-authored PR, not to bypass CI.

Tech Debt

No new technical debt. The immutable upstream revision is pinned normally through Go modules; no dependency fork, local replace or duplicate implementation is introduced.

Follow up after #933: consume OmniSDK's matching NULL propagation fix for WHERE evaluation and cover present, missing, both-missing, JSON null and mismatching optional properties end to end.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jeffreyaven

Copy link
Copy Markdown
Member Author

The new Robot regression was verified failing with the post-933 dependency and passing with the immutable OmniSDK fix revision. Both the new optional-property scenario and the existing SQLite extension smoke scenario pass locally against the downloaded module, with no Go workspace or replace directive. Upstream stackql-labs/omnisdk#60 must merge first. All CI checks will be verified before this PR merges; the repository review requirement may require an administrator merge because this PR is authored by the authenticated maintainer.

@jeffreyaven

Copy link
Copy Markdown
Member Author

Dependency prerequisite is now satisfied: stackql-labs/omnisdk#60 merged after both complete upstream CI jobs passed (build/vet/race/coverage and mocked Robot suite). The pinned acfbd5480179 commit is preserved in upstream main by merge commit 3b89abe79b0171e7481528151909464a6065253c. Waiting for the full StackQL CI matrix before merge.

@jeffreyaven
jeffreyaven merged commit 4f90fd5 into main Nov 18, 2026
39 checks passed
@jeffreyaven
jeffreyaven deleted the nullable-comparison-robot-coverage branch November 18, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant