Skip to content

mcp-uplift - #929

Merged
jeffreyaven merged 8 commits into
mainfrom
mcp-uplift
Nov 16, 2026
Merged

jeffreyaven merged 8 commits into
mainfrom
mcp-uplift

Conversation

@jeffreyaven

@jeffreyaven jeffreyaven commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Description

  • Add a black-box host-native describe_method regression for the review on fix(mcp): quote identifiers in DESCRIBE METHOD for host-native relations #927.
  • Apply finite MCP backend request defaults and streaming-compatible HTTP limits, and exercise both transports.
  • Improve MCP SQL effect detection for nested EXEC and known IaC operations. Complete effect resolution requires backend work and remains open.
  • Align the Go launcher with MCP Go SDK v1.8.0, published 2026-09-14, and exercise current 2026-07-28 and legacy lifecycles.
  • Add private protocol cache metadata and opt-in OAuth JWT resource-server validation against a configured external issuer.
  • Exercise nested EXEC with a counted provider operation, including reconnecting and concurrent clients, and verify cache isolation and OAuth opt-out compatibility.
  • Require TLS 1.2 in the OAuth test fixture, addressing code-scanning alert 70.

Admission and timeout limits wrap backend work after policy and approval, rather than holding a permit while a client considers an approval.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

Evidence

  • go test -count=1 -p 1 ./pkg/mcp_server/...: passed.
  • go test -count=1 -p 1 ./... from packaging/mcpb/go: passed.
  • golangci-lint run --concurrency 2 --timeout 15m ./...: passed using v2.15.0 built with Go 1.27.3.
  • python -m robot --output NONE --log NONE --report NONE --variable "STACKQL_EXE:$env:STACKQL_TEST_BINARY" test\robot\functional\mcp_limits.robot test\robot\functional\stackql_method_schema.robot: 11 passed, 0 failed on native Windows. STACKQL_TEST_BINARY pointed to the feature binary, PYTHONPATH to test\python, GOMAXPROCS=2, PYTHONDONTWRITEBYTECODE=1, and IS_SKIP_MCP_TEST=false.
  • The SQL-policy Robot case passed a dry run only; this checks its structure, not runtime behavior.
  • The host-native method schema Robot suite passed 7 of 7 tests. The new host-native case failed against the earlier local binary and passed against the feature binary.
  • The isolated OAuth Robot scenario passed 31 consecutive native and Docker-config-mode runs after fixing an intermittent HTTP rejection issue.
  • The production OAuth Robot scenario, extended to acquire a JWT from a local Client Credentials token endpoint, passed three isolated runs on Windows. The OAuth-disabled cache/auth suite passed two native cases.
  • The extended OAuth Robot scenario passed three isolated Windows runs covering separate subjects, key rotation, JWKS outage and recovery. The preview-enabled IaC Robot scenario also verified that read-only refusal creates no ledger.
  • The first full Linux ARM64 Robot run completed 860 of 861 tests; the new OAuth case failed on a Robot variable lookup. The corrected production scenario then passed three isolated runs on Windows.
  • Linux ARM64 CI comparison for python cicd/python/build.py --robot-test --config='{ "variables": { "SHOULD_RUN_DOCKER_EXTERNAL_TESTS": "true" } }': main passed 855 of 855; this PR passed 876 of 876. Both runs also passed their additional concurrency variants with the same counts.
  • python -m robot --output NONE --log NONE --report NONE --variable "STACKQL_EXE:$env:STACKQL_TEST_BINARY" test\robot\functional\mcp_effects.robot test\robot\functional\mcp_cache_auth.robot: 15 passed, 0 failed on native Windows. This includes metadata and header rejections, tampered and replayed approval state, and reconnecting and concurrent client audits. STACKQL_TEST_BINARY pointed to the feature binary, GOMAXPROCS=2, PYTHONDONTWRITEBYTECODE=1, and IS_SKIP_MCP_TEST=false.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

The local environment is shared, so the full Robot suite, which uses fixed ports and paths, was not run locally. CI runs the documented full suites and platform checks. Local targeted results and one matching before/after CI comparison are listed above.

An earlier CI run also encountered Docker Hub pull rate limits before Docker tests could start. On commit 6e8f0d90, all 67 executed checks passed. Six checks were skipped on the PR.

Tech Debt

MCP cannot resolve effects hidden behind provider-document or persisted views, aliases, variables, and other indirect relations. #928 tracks the backend semantic effect API. read_only alone is not a complete cloud-effect security boundary.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeffreyaven and others added 7 commits November 16, 2026 13:41
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jeffreyaven
jeffreyaven merged commit 6caadcf into main Nov 16, 2026
73 checks passed
@jeffreyaven
jeffreyaven deleted the mcp-uplift branch November 16, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SECURITY] Enforce MCP request limits and HTTP timeouts

2 participants