Repository navigation
mcp-uplift - #929
Merged
Merged
mcp-uplift#929
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
describe_methodregression for the review on fix(mcp): quote identifiers in DESCRIBE METHOD for host-native relations #927.2026-07-28and legacy lifecycles.Admission and timeout limits wrap backend work after policy and approval, rather than holding a permit while a client considers an approval.
Type of change
Issues referenced.
Evidence
go test -count=1 -p 1 ./pkg/mcp_server/...: passed.go test -count=1 -p 1 ./...frompackaging/mcpb/go: passed.golangci-lint run --concurrency 2 --timeout 15m ./...: passed using v2.15.0 built with Go 1.27.3.python -m robot --output NONE --log NONE --report NONE --variable "STACKQL_EXE:$env:STACKQL_TEST_BINARY" test\robot\functional\mcp_limits.robot test\robot\functional\stackql_method_schema.robot: 11 passed, 0 failed on native Windows.STACKQL_TEST_BINARYpointed to the feature binary,PYTHONPATHtotest\python,GOMAXPROCS=2,PYTHONDONTWRITEBYTECODE=1, andIS_SKIP_MCP_TEST=false.python cicd/python/build.py --robot-test --config='{ "variables": { "SHOULD_RUN_DOCKER_EXTERNAL_TESTS": "true" } }': main passed 855 of 855; this PR passed 876 of 876. Both runs also passed their additional concurrency variants with the same counts.python -m robot --output NONE --log NONE --report NONE --variable "STACKQL_EXE:$env:STACKQL_TEST_BINARY" test\robot\functional\mcp_effects.robot test\robot\functional\mcp_cache_auth.robot: 15 passed, 0 failed on native Windows. This includes metadata and header rejections, tampered and replayed approval state, and reconnecting and concurrent client audits.STACKQL_TEST_BINARYpointed to the feature binary,GOMAXPROCS=2,PYTHONDONTWRITEBYTECODE=1, andIS_SKIP_MCP_TEST=false.Checklist:
Variations
The local environment is shared, so the full Robot suite, which uses fixed ports and paths, was not run locally. CI runs the documented full suites and platform checks. Local targeted results and one matching before/after CI comparison are listed above.
An earlier CI run also encountered Docker Hub pull rate limits before Docker tests could start. On commit
6e8f0d90, all 67 executed checks passed. Six checks were skipped on the PR.Tech Debt
MCP cannot resolve effects hidden behind provider-document or persisted views, aliases, variables, and other indirect relations. #928 tracks the backend semantic effect API.
read_onlyalone is not a complete cloud-effect security boundary.