Repository navigation
Protect plugin release assets from overwrites - #912
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
--clobberfrom the plugin release upload so existing assets are not silently replaced. Write the ZIP checksum in standardsha256sumformat using the ZIP basename.Type of change
Issues referenced.
Follow-up to #910. Related to #902, which remains open for external directory steps.
Evidence
bash -n <script>: passed.git diff --check origin/main...HEAD: passed.bash -swith a mockedgh: passed; ran the helper on a ZIP filename containing a space, verified the sidecar withsha256sum --check, and confirmed the upload arguments omit--clobber.Checklist:
Variations
The helper was tested under Bash with a mocked upload. A full test run, other platforms, and a real release upload were not tested locally. Robot query tests do not exercise this release helper.
Tech Debt
No known new technical debt.