Skip to content

Protect plugin release assets from overwrites - #912

Merged
jeffreyaven merged 1 commit into
mainfrom
fix/pr-910-release-asset-safety
Nov 13, 2026
Merged

jeffreyaven merged 1 commit into
mainfrom
fix/pr-910-release-asset-safety

Conversation

@jeffreyaven

Copy link
Copy Markdown
Member

Description

Remove --clobber from the plugin release upload so existing assets are not silently replaced. Write the ZIP checksum in standard sha256sum format using the ZIP basename.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

Follow-up to #910. Related to #902, which remains open for external directory steps.

Evidence

  • bash -n <script>: passed.
  • git diff --check origin/main...HEAD: passed.
  • bash -s with a mocked gh: passed; ran the helper on a ZIP filename containing a space, verified the sidecar with sha256sum --check, and confirmed the upload arguments omit --clobber.
  • Actual GitHub release upload: not run, to avoid modifying a release.
  • Full Go and robot suites and local lint: not run; this changes a standalone release helper, not query behavior or Go code. PR CI remains to run.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

The helper was tested under Bash with a mocked upload. A full test run, other platforms, and a real release upload were not tested locally. Robot query tests do not exercise this release helper.

Tech Debt

No known new technical debt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jeffreyaven
jeffreyaven merged commit da44f4d into main Nov 13, 2026
48 checks passed
@jeffreyaven
jeffreyaven deleted the fix/pr-910-release-asset-safety branch November 13, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant