Repository navigation
npm-trusted-publishing - #880
Merged
Merged
Conversation
Publish @stackql/mcp-server from the mcp-packaging workflow via npm trusted publishing (GitHub Actions OIDC, provenance attached) instead of a local npm login + OTP publish. Adds the idempotent make npm-publish target (publishes the same npm/ directory that npm-pack packs) and the npm-publish job gated like the other sdk publish jobs. PyPI stays manual. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 of 10 tasks
general-kroll-4-life
pushed a commit
that referenced
this pull request
Oct 31, 2026
Publish @stackql/mcp-server from the mcp-packaging workflow via npm trusted publishing (GitHub Actions OIDC, provenance attached) instead of a local npm login + OTP publish. Adds the idempotent make npm-publish target (publishes the same npm/ directory that npm-pack packs) and the npm-publish job gated like the other sdk publish jobs. PyPI stays manual. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the npm wrapper publish (release process step 8a) from a local
npm login+ OTP publish into themcp-packagingworkflow, authenticated with GitHub Actions OIDC via npm trusted publishing. npm attaches a provenance attestation automatically. PyPI (8b) stays manual and is out of scope.Changes:
packaging/mcpb/Makefile: newnpm-publishtarget on the same contract as the other<vector>-publishtargets (idempotent via a registry existence check, prints the resulting coordinate). It publishes the samenpm/directory thatnpm-packpacks, so the artefact is identical:package.json,README.md,bin/stackql-mcp.js,platforms.json.npm-packis relabelled as the local fallback..github/workflows/mcp-packaging.yml: newnpm-publishjob next tocargo-publish/dotnet-publish/go-publish, same gate (is_publish == 'true') andneeds: [version, sdk], job-scopedid-token: write. Top-levelpermissionsstayscontents: read. NoNODE_AUTH_TOKEN/NPM_TOKENanywhere. Node24.22.1ships npm 11.x (>= 11.5.1 OIDC minimum)..github/workflows/mcp-registry-publish.yml: comment and input description text only.packaging/mcpb/README.md,docs/stackql_release_process.md: npm is published by CI; manual commands relabelled as the fallback; step 10 now instructs runningmake npm-manifestlocally for the plugin stamp (the runner's stamp is discarded).Design notes for debate once:
stackql, repostackql, workflowmcp-packaging.yml, environment blank,npm publishticked). A fresh configuration expires if no publish succeeds within 2 days, and cannot be edited after creation.packaging/mcpb/npm/package.json,bin/stackql-mcp.jsand the renderer scripts are untouched. The PyPI, cargo, go, dotnet, OCI and registry jobs are untouched.npm view ... dist.attestations.url,npm pack --dry-runfile list comparison against the previous manual publish,make check-published).Type of change
Issues referenced.
None.
Evidence
python -c "import yaml; ..."parsing both edited workflows: passed. The new job resolves toneeds: ['version', 'sdk'],permissions: {contents: read, id-token: write},setup-nodewithnode-version: 24.22.1,registry-url: https://registry.npmjs.org.make -n npm-publish VERSION=0.0.0(frompackaging/mcpb, dry run, executes nothing): passed; recipe chain ischeck-version->openai-plugin-manifest->npm-manifest-> existence guard ->npm publish --dry-run --access public && npm publish --access public.npm/package.jsonhas no lifecycle scripts andfiles+ implicitpackage.jsonyield exactly the four expected entries, so the job needs nonpm ci.mcp-packagingPR validation (triggered by this PR'spackaging/**and workflow path changes) exercises thetest/bundle/sdkjobs; thenpm-publishjob is correctly skipped on PRs becauseis_publish != 'true'.npm publish, workflow dispatch (deliberately, per the work order; first OIDC publish is on the next real release).Checklist:
Variations
No Go code, robot tests, or unit tests are affected (CI workflow, Makefile and docs only), so the unit / robot / lint checklist items are not applicable. The relevant validation is the
mcp-packagingPR check on this branch plus the dry-run evidence above; the publish path itself can only be validated on the first dispatched release, with the verification steps documented in section 8a of the release process.Tech Debt
None. The manual npm publish path is retained as a documented fallback, not as a parallel process.