Repository navigation
wire-ml-dsa-provider-verification - #869
Conversation
Pin both SDK migrations and propagate the existing opt-in verification setting through all document-backed omnisdk discovery and execution paths. Add ephemeral-key Robot coverage for both SDKs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve explicit verification opt-out and document internal helper tests. Split fixture generation and use os.Root for confined document reads and writes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use isolated offline Docker processes for the Docker matrix and honor preinstalled binaries. Cross-build an ephemeral fixture generator for WSL, where Go is not installed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| github.com/spf13/viper v1.10.1 | ||
| github.com/stackql-labs/omnisdk v0.1.6-alpha05 | ||
| github.com/stackql/any-sdk v0.6.1-beta01 | ||
| github.com/stackql-labs/omnisdk v0.1.6-alpha05.0.20261023204515-412bd2392e4e |
There was a problem hiding this comment.
create new semver manually. Pre release increment or some such is fine. Also, ensure the tag is on the trunk branch. I do it pre merge but whatever mechanism you prefer is fine
There was a problem hiding this comment.
Implemented at 9153e22: named releases any-sdk v0.6.1-beta02, omnisdk v0.1.7-alpha01, signing v0.1.0-alpha01, followed by go mod tidy. All three library branches were squashed to one final tagged commit and their tags are published/publicly downloadable. The run sheet now explicitly requires Create a merge commit (no squash/rebase) for SDKs and the registry signing module so the exact tagged commits reach main, while core remains squash-and-merge. Tags are not yet on trunk because the PRs remain unmerged. Local rebuilt dual-SDK signature Robots pass 6/6; the full updated CI matrix is running. I will confirm the result here once complete.
There was a problem hiding this comment.
Final verification: all 37 checks passed at 9153e22 with the published semver dependencies, including the complete native/WSL/Docker/PostgreSQL-sharded Robot matrix: https://github.com/stackql/stackql/actions/runs/40050605476. All library PR checks are green too. Each library tag matches its single feature commit; PR descriptions explicitly require Create a merge commit (not squash/rebase), and core remains squash-and-merge. The tagged commits are intentionally not yet on main because I have not merged the PRs. Please re-review the semver pins and the updated merge run sheet.
Use any-sdk v0.6.1-beta02, omnisdk v0.1.7-alpha01 and signing v0.1.0-alpha01 instead of feature-commit pseudo-versions. Tidy module checksums and verify both SDK paths with the signature Robot suite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Cutover progress: provider-tests #2 merged (6e4189b); omnisdk #23 merged with a merge commit (d842500), and v0.1.7-alpha01 is verified as an ancestor of main. Omnisdk issue #17 auto-closed. No rebase was needed: both library/core bases were current; the concurrent omnisdk gap-narrow work remains on its own branch and was not touched. Next dependency is any-sdk #155: CI is green but GitHub still requires native approval on that PR. Requested general-kroll-4-life there; no branch-protection bypass. Core merge/release and registry cutover remain gated until the approval and tag-preserving any-sdk merge. |
Summary
nopVerify:true; wire explicit verification into document-backed discovery, views, table descriptions, graph plans and IaC paths, not just the legacy SDK.Validation
Approved design decisions
The maintainer approved removing legacy verification outright and replacing the issues' RFC 8785 proposal with exact-byte payloads: the corpus contains aliases and large integer schema limits which must not be rewritten or rounded. Archive verification and rollback/freshness protection remain out of scope (#832).
Tagged dependencies (review follow-up)
All three tags are published and publicly downloadable. Both SDKs also pin the named signing release. Core go.mod/go.sum were updated with GOWORK=off and go mod tidy; the rebuilt CLI passed all six dual-SDK signature Robot scenarios. Omnisdk's v0.1.6-alpha14 is on an independent gap-narrow branch, so this migration has a distinct v0.1.7-alpha01 prerelease. No unrelated feature-branch code was imported.
Coordination: merge methods and release order
Do not move published tags. If library code needs further changes, publish a new prerelease and rerun core CI. Verification remains opt-in; legacy sidecar-only artifacts need republishing before opting in. Existing local packaging edits were not included.
Latest semver CI verification
All 37 build/test/analysis checks passed on core commit 9153e22 using the named releases, including the complete native Windows/macOS/Linux, WSL, Docker and PostgreSQL-sharded Robot matrix, lint and MCP platform checks. Evidence: https://github.com/stackql/stackql/actions/runs/40050605476. The optional Claude review workflow was skipped; no failing Robot tests were skipped. All four companion PRs are green as well. Required maintainer approval remains; no PRs have been merged and tagged commits reach trunk only through the merge-commit steps above.
Closes #856