Skip to content

aws-okta-flask-migration - #482

Merged
general-kroll-4-life merged 1 commit into
mainfrom
feature/flask-aws-okta
Dec 16, 2024
Merged

general-kroll-4-life merged 1 commit into
mainfrom
feature/flask-aws-okta

Conversation

@general-kroll-4-life

@general-kroll-4-life general-kroll-4-life commented Dec 16, 2024 •

Copy link
Copy Markdown
Contributor

Summary:

  • Migrated aws mocks from mockserver to flask.
  • Migrated okta mocks from mockserver to flask.

Description

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

#478

Evidence

  • okta robot tests pass with no changes to test definitions.
  • aws robot tests pass with minimal changes to test definitions. Thos changes enacted are due to confusing velocity templated tests in prior state; moved to simpler configuration post change.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

N/A.

Tech Debt

@gitguardian

gitguardian Bot commented Dec 16, 2024 •

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7072118 Triggered Generic Password 1645465 test/python/flask/aws/templates/list_users_01.xml View secret
14870993 Triggered Generic Password 1645465 test/python/flask/aws/templates/list_users_01.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Summary:

- Migrated `aws` mocks from `mockserver` to `flask`.
- Migrated `okta` mocks from `mockserver` to `flask`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant