Skip to content

gcp-flask-migration - #480

Merged
general-kroll-4-life merged 1 commit into
mainfrom
feature/excise-mockserver-google
Dec 11, 2024
Merged

general-kroll-4-life merged 1 commit into
mainfrom
feature/excise-mockserver-google

Conversation

@general-kroll-4-life

@general-kroll-4-life general-kroll-4-life commented Dec 11, 2024 •

Copy link
Copy Markdown
Contributor

Description

  • Migrate google mocks from mockserver to flask.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

#478

Evidence

  • Google robot tests pass post-migration.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

N/A.

Tech Debt

@general-kroll-4-life
general-kroll-4-life force-pushed the feature/excise-mockserver-google branch from f36113e to 94d5699 Compare December 11, 2024 11:28
Summary:

- Migrated `google` mocks from `mockserver` to `flask`.
- Flask lifeccycle not well controlled by robot process lib keyword `Terminate All Processes    kill=True`, so shell hack kills flask before robot repeats.
@general-kroll-4-life
general-kroll-4-life force-pushed the feature/excise-mockserver-google branch from 94d5699 to 232a724 Compare December 11, 2024 11:52
@general-kroll-4-life
general-kroll-4-life merged commit 86ff3e9 into main Dec 11, 2024
@general-kroll-4-life
general-kroll-4-life deleted the feature/excise-mockserver-google branch December 11, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant