Skip to content

github-flask-migration - #479

Merged
general-kroll-4-life merged 1 commit into
mainfrom
feature/excise-gh-mockserver
Dec 11, 2024
Merged

general-kroll-4-life merged 1 commit into
mainfrom
feature/excise-gh-mockserver

Conversation

@general-kroll-4-life

@general-kroll-4-life general-kroll-4-life commented Dec 11, 2024 •

Copy link
Copy Markdown
Contributor

Description

  • Bare bones TLS for flask.
  • Added robot keyword to run github mocks.
  • Response bodies as json / jinja templates.
  • Added http logging for graphql functionality.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

#478

Evidence

  • Test migration success is assessable by automated (robot) tests passing.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

  • The http logging on grapohql is untested. Making the call it is a nice to have on a best effort basis only.

Tech Debt

  • No technical debt is introduced in this change.
  • This change fixes some technical debt.

Summary:

- Bare bones TLS for `flask`.
- Added robot keyword to run `github` mocks.
- Response bodies as `json` / `jinja` templates.
- Added `http` logging for `graphql` functionality.
@general-kroll-4-life
general-kroll-4-life merged commit 1192ed0 into main Dec 11, 2024
@general-kroll-4-life
general-kroll-4-life deleted the feature/excise-gh-mockserver branch December 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant