Closed
Conversation
* Update dependencies for security updates * Switch to python 3.12 in pyproject.toml * Fix two spelling typos * script/upgrade.py: remove note about tomllib which doesn't support writing TOML files
Contributor
Author
|
So... despite this passing the CI checks, this breaks support for Python << 3.12. The problem is urllib3 and cryptography are kept at older & vulnerable versions if we support python << 3.10. Not sure what the right trade off is here. |
sontek
approved these changes
Aug 6, 2025
Contributor
|
Yeah, I guess the concern is since this is a client tool we might be breaking customers utilization of it. I thought Python 3.9 was still in security support mode this year so in theory it should still be getting patches. So I guess its just that cryptography and urllib don't want to support it? |
Contributor
Author
|
Superseded by #79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
why
Security and speeling.
testing
poetry install; just testdocs
N/A