chore: move snippets-related expressions in the snippet class#105
Merged
albertodonato merged 1 commit intomainfrom Feb 4, 2026
Merged
chore: move snippets-related expressions in the snippet class#105albertodonato merged 1 commit intomainfrom
albertodonato merged 1 commit intomainfrom
Conversation
### what - move pagination and result JMESpath expressions into the snippets definitions they belong to. - drop the "pagination" flag on the class since it's now possible to check if there's a page expression directly. ### why keep all the snippets-related configurations in one place ### testing tests still pass, alst tested manually ### docs n/a
fwereade
approved these changes
Feb 4, 2026
Contributor
fwereade
left a comment
fwereade
left a comment
There was a problem hiding this comment.
Very neat, thank you. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
they belong to.
there's a page expression directly.
why
keep all the snippets-related configurations in one place
testing
tests still pass, also tested manually in sandbox
docs
n/a