remove report method

dmelikyan · dmelikyan · commit 6e67111acb7e · 2018-09-25T11:26:07.000Z
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ Learn more on the [features](https://stackimpact.com/features/) page (with scree
 
 #### How it works
 
-The StackImpact profiler agent is imported into a program and used as a normal package. When the program runs, various sampling profilers are started and stopped automatically by the agent and/or programmatically using the agent methods. The agent periodically reports recorded profiles and metrics to the StackImpact Dashboard. If an application has multiple processes, also referred to as workers, instances or nodes, only one or two processes will have active agents at any point of time.
+The StackImpact profiler agent is imported into a program and used as a normal package. When the program runs, various sampling profilers are started and stopped automatically by the agent and/or programmatically using the agent methods. The agent periodically reports recorded profiles and metrics to the StackImpact Dashboard. The agent can also operate in manual mode, which should be used in development only.
 
 
 #### Documentation
@@ -165,4 +165,4 @@ To enable debug logging, add `debug = True` to startup options. If the debug log
 
 ## Overhead
 
-The agent overhead is measured to be less than 1% for applications under high load. For applications that are horizontally scaled to multiple processes, StackImpact agents are only active on a small subset of the processes at any point of time, therefore the total overhead is much lower.
+The agent overhead is measured to be less than 1% for applications under high load.
diff --git a/examples/demo/flask_app.py b/examples/demo/flask_app.py
@@ -1,4 +1,4 @@
-#env AGENT_KEY=agnetkeyhere FLASK_APP=examples/flask_app.py flask run -p 5010
+#env AGENT_KEY=agnetkeyhere FLASK_APP=examples/demo/flask_app.py flask run -p 5010
 
 from __future__ import print_function
 
@@ -28,6 +28,7 @@
 # StackImpact agent initialization
 agent = stackimpact.start(
     agent_key = os.environ['AGENT_KEY'],
+    dashboard_address = os.environ['DASHBOARD_ADDRESS'],
     app_name = 'ExamplePythonFlaskApp',
     app_version = '1.0.0',
     debug = True)
diff --git a/setup.py b/setup.py
@@ -6,7 +6,7 @@ def read(fname):
 
 setup(
     name = 'stackimpact',
-    version = '1.2.3',
+    version = '1.2.4',
     description = 'StackImpact Python Profiler',
     long_description = read('README.rst'),
     author = 'StackImpact',
diff --git a/stackimpact/agent.py b/stackimpact/agent.py
@@ -51,7 +51,7 @@ def __exit__(self, exc_type, exc_value, traceback):
 
 class Agent(object):
 
-    AGENT_VERSION = "1.2.3"
+    AGENT_VERSION = "1.2.4"
     SAAS_DASHBOARD_ADDRESS = "https://agent-api.stackimpact.com"
 
     def __init__(self, **kwargs):
@@ -261,6 +261,12 @@ def stop_func():
             duration = time.time() - start_timestamp
             self.span_reporter.record_span(name, duration)
 
+            if not self.get_option('auto_profiling'):
+                self.config_loader.load(True)
+                if selected_reporter:
+                    selected_reporter.report(True);
+                self.message_queue.flush(True)
+
             self.span_active = False
 
         return Span(stop_func)
@@ -320,20 +326,6 @@ def stop_tf_profiler(self):
         self._stop_profiler(self.tf_reporter)
 
 
-    def report(self):
-        if not self.agent_started or self.get_option('auto_profiling'):
-            return
-
-        self.config_loader.load(True)
-
-        self.cpu_reporter.report(True);
-        self.allocation_reporter.report(True);
-        self.block_reporter.report(True);
-        self.tf_reporter.report(True);
-
-        self.messageQueue.flush(True)
-
-
     def destroy(self):
         if not self.agent_started:
             self.log('Agent has not been started')
diff --git a/stackimpact/profilers/allocation_profiler.py b/stackimpact/profilers/allocation_profiler.py
@@ -91,7 +91,7 @@ def build_profile(self, duration):
                 'category': Metric.CATEGORY_MEMORY_PROFILE,
                 'name': Metric.NAME_UNCOLLECTED_ALLOCATIONS,
                 'unit': Metric.UNIT_BYTE,
-                'unit_interval': None,
+                'unit_interval': 1,
                 'profile': self.profile
             }]
 
diff --git a/tests/agent_test.py b/tests/agent_test.py
@@ -50,7 +50,6 @@ def test_profile(self):
             dashboard_address = 'http://localhost:5001',
             agent_key = 'key1',
             app_name = 'TestPythonApp',
-            auto_profiling = False,
             debug = True
         )
 
@@ -77,7 +76,6 @@ def test_with_profile(self):
             dashboard_address = 'http://localhost:5001',
             agent_key = 'key1',
             app_name = 'TestPythonApp',
-            auto_profiling = False,
             debug = True
         )
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,6 @@ def test_profile(self):`
`50`	`50`	`dashboard_address = 'http://localhost:5001',`
`51`	`51`	`agent_key = 'key1',`
`52`	`52`	`app_name = 'TestPythonApp',`
`53`		`- auto_profiling = False,`
`54`	`53`	`debug = True`
`55`	`54`	`)`
`56`	`55`
`@@ -77,7 +76,6 @@ def test_with_profile(self):`
`77`	`76`	`dashboard_address = 'http://localhost:5001',`
`78`	`77`	`agent_key = 'key1',`
`79`	`78`	`app_name = 'TestPythonApp',`
`80`		`- auto_profiling = False,`
`81`	`79`	`debug = True`
`82`	`80`	`)`
`83`	`81`