Skip to content

Commit b4e35ad

Browse files
author
Dmitry Tarasov
committed
Fix some TODOs
1 parent e3d686c commit b4e35ad

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/Stackify/Log/Transport/ExecTransport.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ public function __construct($apiKey, array $options = array())
2323
if (!function_exists('exec')) {
2424
throw new InitializationException("PHP function 'exec' is not available, is it disabled for security reasons?");
2525
}
26-
// @TODO windows support
26+
if ('WIN' === strtoupper(substr(PHP_OS, 0, 3))) {
27+
throw new InitializationException('Exec transport is not supposed to work on Windows');
28+
}
2729
}
2830

2931
protected function getAllowedOptions()
@@ -73,7 +75,6 @@ protected function send($data)
7375

7476
private function escapeArg($string)
7577
{
76-
// @TODO test special chars
7778
// http://stackoverflow.com/a/1250279/871861
7879
return str_replace("'", "'\"'\"'", $string);
7980
}

0 commit comments

Comments
 (0)