Skip to content

Commit f10293d

Browse files
eric-martineric-martin
committed
Remove configured location from the environment details
1 parent ffa7bd8 commit f10293d

3 files changed

Lines changed: 4 additions & 10 deletions

File tree

‎pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<dependency>
2525
<groupId>com.stackify</groupId>
2626
<artifactId>stackify-api</artifactId>
27-
<version>1.0.0</version>
27+
<version>1.0.1-SNAPSHOT</version>
2828
</dependency>
2929

3030
<!-- Runtime dependencies -->

‎src/main/java/com/stackify/api/common/EnvironmentDetails.java‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,10 @@ public class EnvironmentDetails {
3131
/**
3232
* Creates an environment details object with system information
3333
* @param application The configured application name
34-
* @param location The configured application location
3534
* @param environment The configured application environment
3635
* @return The EnvironmentDetail object
3736
*/
38-
public static EnvironmentDetail getEnvironmentDetail(final String application, final String location, final String environment) {
37+
public static EnvironmentDetail getEnvironmentDetail(final String application, final String environment) {
3938

4039
// lookup the hostname
4140

@@ -59,7 +58,6 @@ public static EnvironmentDetail getEnvironmentDetail(final String application, f
5958
environmentBuilder.deviceName(hostName);
6059
environmentBuilder.appLocation(currentPath);
6160
environmentBuilder.configuredAppName(application);
62-
environmentBuilder.configuredLocationName(location);
6361
environmentBuilder.configuredEnvironmentName(environment);
6462

6563
return environmentBuilder.build();

‎src/test/java/com/stackify/api/common/EnvironmentDetailsTest.java‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public class EnvironmentDetailsTest {
4343
@Test
4444
public void testGetEnvironmentDetail() throws UnknownHostException {
4545
String application = "application";
46-
String location = "location";
4746
String environment = "environment";
4847
String hostName = "hostName";
4948

@@ -53,15 +52,14 @@ public void testGetEnvironmentDetail() throws UnknownHostException {
5352
PowerMockito.mockStatic(InetAddress.class);
5453
PowerMockito.when(InetAddress.getLocalHost()).thenReturn(inetAddress);
5554

56-
EnvironmentDetail env = EnvironmentDetails.getEnvironmentDetail(application, location, environment);
55+
EnvironmentDetail env = EnvironmentDetails.getEnvironmentDetail(application, environment);
5756

5857
Assert.assertNotNull(env);
5958

6059
Assert.assertEquals(hostName, env.getDeviceName());
6160
Assert.assertNotNull(env.getAppLocation());
6261
Assert.assertNull(env.getAppName());
6362
Assert.assertEquals(application, env.getConfiguredAppName());
64-
Assert.assertEquals(location, env.getConfiguredLocationName());
6563
Assert.assertEquals(environment, env.getConfiguredEnvironmentName());
6664
}
6765

@@ -72,21 +70,19 @@ public void testGetEnvironmentDetail() throws UnknownHostException {
7270
@Test
7371
public void testGetEnvironmentDetailHostnameException() throws UnknownHostException {
7472
String application = "application";
75-
String location = "location";
7673
String environment = "environment";
7774

7875
PowerMockito.mockStatic(InetAddress.class);
7976
PowerMockito.when(InetAddress.getLocalHost()).thenThrow(new RuntimeException());
8077

81-
EnvironmentDetail env = EnvironmentDetails.getEnvironmentDetail(application, location, environment);
78+
EnvironmentDetail env = EnvironmentDetails.getEnvironmentDetail(application, environment);
8279

8380
Assert.assertNotNull(env);
8481

8582
Assert.assertNull(env.getDeviceName());
8683
Assert.assertNotNull(env.getAppLocation());
8784
Assert.assertNull(env.getAppName());
8885
Assert.assertEquals(application, env.getConfiguredAppName());
89-
Assert.assertEquals(location, env.getConfiguredLocationName());
9086
Assert.assertEquals(environment, env.getConfiguredEnvironmentName());
9187
}
9288
}

0 commit comments

Comments
 (0)