Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Add contribution guidelines - #9

Merged
jpvillaisaza merged 1 commit into
tutorialsfrom
add-contribution-guidelines
May 20, 2016
Merged

Add contribution guidelines#9
jpvillaisaza merged 1 commit into
tutorialsfrom
add-contribution-guidelines

Conversation

@jpvillaisaza

Copy link
Copy Markdown
Member

No description provided.

@jpvillaisaza jpvillaisaza added this to the 2016-05-15 milestone May 5, 2016
@jpvillaisaza jpvillaisaza self-assigned this May 5, 2016
@jpvillaisaza

Copy link
Copy Markdown
Member Author

@nebtrx Can you rebase against tutorials? This branch is missing a lot things we have there, which makes it harder to see the changes.

@jpvillaisaza

Copy link
Copy Markdown
Member Author

(Or not missing, the changes are displayed here.)

@nebtrx

nebtrx commented May 17, 2016

Copy link
Copy Markdown
Contributor

so...should I still rebase?

@jpvillaisaza

Copy link
Copy Markdown
Member Author

@nebtrx Yes, please. The pull request says there are 22 commits here.

Comment thread .github/CONTRIBUTING.md Outdated
@@ -0,0 +1,19 @@
# Contributing to Haskell DevEd

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nebtrx Let's remove "Haskell DevEd" from here. We're starting with Haskell, but we could have tutorials on other languages and tools.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@nebtrx
nebtrx force-pushed the add-contribution-guidelines branch from a5616a6 to afedfb6 Compare May 17, 2016 20:32
@nebtrx

nebtrx commented May 17, 2016

Copy link
Copy Markdown
Contributor

Rebased!

Comment thread README.md Outdated
* The content of this tutorials are licensed under a Creative Commons
Attribution-NonCommercial-ShareAlike 4.0 International license
([CC BY-NC-SA 4.0](http://creativecommons.org/licenses/by-nc-sa/4.0/)).
([CC BY-NC-SA 4.0](http://creativecommons.org/licenses/by-nc-sa/4.0/)) and the exposed source code is licensed under the [MIT License](http://opensource.org/licenses/mit-license.php).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nebtrx Let's keep the License header for this item and change it to something like this:

  • The content of these tutorials is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International license (CC BY-NC-SA 4.0).
  • The code in these tutorials is licensed under the MIT license.

Also, let's change the MIT link to https://opensource.org/licenses/MIT and remove the first item (No warranty...).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger!

@jpvillaisaza jpvillaisaza modified the milestones: 2016-05-14, 2016-05-21 May 18, 2016
Comment thread .github/CONTRIBUTING.md Outdated

First off, thanks for taking the time to contribute! :tada::+1:

The following is a set of guidelines for contributing to Haskell DevEd, which are

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haskell DevEd is no longer the name of the project. Please verify with @jpvillaisaza on which name should we use now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's change it to Stack Builders Tutorials as we did with the title of this file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we are using "which are" when referring to a single thing. Will be better if it is "which is"

@nebtrx nebtrx May 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, now which are makes sense

@jpvillaisaza

Copy link
Copy Markdown
Member Author

@nebtrx Please remove tutorials/haskell/snap-web-app/code/src/Todo/Types.hs from this pull request.

Comment thread .github/CONTRIBUTING.md Outdated

## Contributing Guide

1. Fork it

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants