This repository was archived by the owner on Aug 27, 2022. It is now read-only.
Minor typographical changes - #52
Merged
javcasas merged 2 commits intoJul 13, 2017
Merged
Conversation
javcasas
approved these changes
Jul 13, 2017
javcasas
left a comment
javcasas
left a comment
Contributor
There was a problem hiding this comment.
Yes, my English becomes rusty if I don't oil it often enough.
|
|
||
| Well, there is a way to do that. Can you see the `Generic` instances we have introduced somehow? | ||
| We are going to leverage these instances for us. In fact, I have not invented this, the [Argonaut](https://github.com/purescript-contrib/purescript-argonaut) guys did it! | ||
| We are going to take advantage of these instances. In fact, I have not invented this - the [Argonaut](https://github.com/purescript-contrib/purescript-argonaut) guys did it! |
Contributor
There was a problem hiding this comment.
Is it worth it changing the guys to folks there?
Member
Author
There was a problem hiding this comment.
Good question. If you know for a fact that all of the people on the team were men, I think it's ok to say "guys" - otherwise we should probably make it more gender-neutral.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.