Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Tutorials support English and Spanish - #118

Open
felixminom wants to merge 3 commits into
tutorialsfrom
tutorials-language
Open

Tutorials support English and Spanish#118
felixminom wants to merge 3 commits into
tutorialsfrom
tutorials-language

Conversation

@felixminom

@felixminom felixminom commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

This WIP PR resolves stackbuilders/stackbuilders.com#958

In order to keep the format of routes (ex: /es/services) I have added a /es directory that contains all templates and files needed to keep this behavior. It was needed tutorial.md to be duplicated in this /es directory to be able to create a new route that contains the /es prefix, this is why this PR contains a lot of files added.

This is how site looks now.
image

image

TODO:

  • Update contributing guideline.
  • Create tags' spanish version.

Could you take a look a this, please ?
@sestrella
@jpvillaisaza

@felixminom
felixminom requested a review from jpvillaisaza April 9, 2020 14:19
@felixminom felixminom changed the title [WIP] Tutorials support English and Spanish Tutorials support English and Spanish Apr 9, 2020
@cptrodolfox cptrodolfox self-assigned this Apr 28, 2020
@cptrodolfox

Copy link
Copy Markdown

I will continue working on this PRs based on the work done by @felixminom .

@cptrodolfox

cptrodolfox commented Apr 29, 2020

Copy link
Copy Markdown

I will have to pause as the complexity of this PR is too great at the moment. However, I have updated the work done so far.

What works:

  • Creation of Spanish and English version routes from the same tutorial file.
  • Spanish version of the tags for both english and Spanish.
  • Proper Spanish context for this tag indexes given by the html template /es/templates/tutorials-list.html and proper title.

What does not work:

  • Tags inside Spanish version of the tutorials link to the English version of the tag indices.

Future work:

  • Use a file extension hierarchy to create Spanish and English version of the tutorials (*.es.md and *.md). If a .es.md version of the file is found use that one to create the Spanish tutorial, instead of the .md version.

@jpvillaisaza
jpvillaisaza removed their request for review October 21, 2020 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants