Skip to content

fix: Update gomod2nix.toml #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 1 commit into from
Aug 14, 2024
Merged

fix: Update gomod2nix.toml #314

sbernauer merged 1 commit into from
Aug 14, 2024

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 2, 2024

Description

Requested in #313 (comment)
I have no idea what I'm doing

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer mentioned this pull request Aug 2, 2024
Merged
@sbernauer sbernauer self-assigned this Aug 2, 2024
@sbernauer sbernauer requested a review from NickLarsenNZ August 2, 2024 12:02
NickLarsenNZ
NickLarsenNZ approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit e9e0a0d Aug 14, 2024
@sbernauer sbernauer deleted the fix/update-gomod2nix branch August 14, 2024 11:44
@Techassi Techassi mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @NickLarsenNZ