-
-
Notifications
You must be signed in to change notification settings - Fork 3
Restore broken Nix build #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you just did a niv update, but if it was something else, would you mind noting it in the description (just so it is stored in the merge commit).
|
Yep, 2 was just a niv update. |
| # so we download it instead, and tell it to use that | ||
| SWAGGER_UI_DOWNLOAD_URL = "file://${pkgs.fetchurl { | ||
| url = "https://github.com/swagger-api/swagger-ui/archive/refs/tags/v5.17.3.zip"; | ||
| hash = "sha256-zrb8feuuDzt/g6y7Tucfh+Y2BWZov0soyNPR5LBqKx4="; | ||
| }}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:chefkiss:
| # Build script only supports fetching from HTTP, not file URLs | ||
| # Last path element decides the cache key, which we rely on above | ||
| SWAGGER_UI_DOWNLOAD_URL = "file:///invalid-path/swagger-ui.zip"; | ||
| # so we download it instead, and tell it to use that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nightkr this happens to solve my problem as well. But i am currently facing a situation where nix throws this error when trying to copy the zip file to the target build folder.
{ code: 13, kind: PermissionDenied, message: "Permission denied" }
Is this something you have faced before? i'd appreciate your thoughts on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the Nix daemon itself throws the error, or build.rs does? Can't say it's something I recognize immediately, but if I were you I'd try to patch utoipa-swagger-ui's build.rs to dump out the environment (what absolute path is it writing to, who's it running as, how much of the path exists, what're the permissions like, etc etc etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the build.rs does throws this during the nix build. and yes i can identify the various environment related details. Except i'm new to nix and i don't know if i actually can modify the permissions so the build passes. but i'll research more on it. thanks for your prompt response.
Description
24.7.0 breaks the Nix build for a few reasons:
This PR fixes 1 directly, and 2 by updating all pinned Nix libraries.
Definition of Done Checklist