Skip to content

Fix: Release bump in Cargo.TOMLs #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickLarsenNZ merged 4 commits into from
Jul 10, 2024
Merged

Fix: Release bump in Cargo.TOMLs #824

NickLarsenNZ merged 4 commits into from
Jul 10, 2024

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jul 10, 2024

Description

This was forgotten in #823.

Important

After merging, the remote tags need deleting:

git push --delete origin k8s-version-0.1.1
git push --delete origin stackable-certs-0.3.1
git push --delete origin stackable-operator-0.70.0
git push --delete origin stackable-operator-derive-0.3.1
git push --delete origin stackable-telemetry-0.2.0
git push --delete origin stackable-versioned-0.1.1
git push --delete origin stackable-webhook-0.3.1

And anyone who has the tags already can remove them with:

git tag --delete k8s-version-0.1.1
git tag --delete stackable-certs-0.3.1
git tag --delete stackable-operator-0.70.0
git tag --delete stackable-operator-derive-0.3.1
git tag --delete stackable-telemetry-0.2.0
git tag --delete stackable-versioned-0.1.1
git tag --delete stackable-webhook-0.3.1

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@NickLarsenNZ NickLarsenNZ self-assigned this Jul 10, 2024
@Techassi Techassi self-requested a review July 10, 2024 10:01
Techassi

This comment was marked as resolved.

Sign in to view

@NickLarsenNZ NickLarsenNZ requested a review from Techassi July 10, 2024 10:05
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 045af8d Jul 10, 2024
@NickLarsenNZ NickLarsenNZ deleted the fix/release-bump-in-cargo-tomls branch July 10, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickLarsenNZ @Techassi