Skip to content

chore!: Rename KubernetesServiceType back to ServiceType #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 2 commits into from
May 22, 2024
Merged

chore!: Rename KubernetesServiceType back to ServiceType #791

sbernauer merged 2 commits into from
May 22, 2024

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented May 22, 2024 •
edited
Loading

Description

Fixup of #773

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer mentioned this pull request May 22, 2024
Merged
@sbernauer sbernauer requested a review from nightkr May 22, 2024 10:20
@sbernauer sbernauer added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit e1f6fe8 May 22, 2024
@sbernauer sbernauer deleted the chore/rename-kubernetes-service-type branch May 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nightkr nightkr nightkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @nightkr