Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented May 6, 2024

Description

Replaces #562
Needed by stackabletech/listener-operator#57
First raised a year ago here

If i use the ListenerClass external-stable on IONOS k8s the LoadBalancer svc is not reachable. I did find out it's because we set externalTrafficPolicy: Local on the svc here.
This PR simply allows users to configure that field, which is than passed to the created Service. We leave the default as-is at Local, so we don't have any breaking change.

This change is needed for external-stable to work on IONOS!

Some background info on that feature

CRD change

---
apiVersion: listeners.stackable.tech/v1alpha1
kind: ListenerClass
metadata:
  name: public
spec:
  serviceType: LoadBalancer
  # NEW:
  serviceExternalTrafficPolicy: Local # or Cluster, defaults to Local
# Tasks
- [ ] operator-rs change
- [ ] Read and use new field in listener-op

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [x] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

NickLarsenNZ
NickLarsenNZ previously approved these changes May 6, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some comments

sbernauer and others added 3 commits May 7, 2024 07:44
NickLarsenNZ
NickLarsenNZ previously approved these changes May 7, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NickLarsenNZ
NickLarsenNZ previously approved these changes May 7, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer requested a review from nightkr May 13, 2024 08:28
@sbernauer sbernauer requested a review from nightkr May 16, 2024 09:26
@sbernauer sbernauer self-assigned this May 16, 2024
@sbernauer
Copy link
Member Author

There were no further comments during the voting phase, merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/24.7.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. type/internal-debt

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants