Skip to content

fix: Construction of OIDC endpoint when rootPath has no trailing slash#718

Merged
sbernauer merged 17 commits intomainfrom
fix/oidc-endpoint
Nov 25, 2024
Merged

fix: Construction of OIDC endpoint when rootPath has no trailing slash#718
sbernauer merged 17 commits intomainfrom
fix/oidc-endpoint

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 22, 2024 •
edited
Loading

Description

Fixes #716

Deploying nifi into the e2e-sec demo:

With rootPath: /realms/demo

0.0.0-dev: https://85.215.194.243:30584/realms/.well-known/openid-configuration (obviously broken) => Caused by: org.springframework.web.client.HttpClientErrorException$NotFound: 404 Not Found: "{"error":"Realm does not exist"}"
This PR: https://85.215.194.243:30584/realms/demo/.well-known/openid-configuration => Correct ✔️

With rootPath: /realms/demo/

0.0.0-dev: https://85.215.194.243:30584/realms/demo/.well-known/openid-configuration => Correct ✔️
This PR: https://85.215.194.243:30584/realms/demo/.well-known/openid-configuration => Correct ✔️

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

sbernauer
sbernauer commented Nov 22, 2024
View reviewed changes
@sbernauer
Copy link
Member Author

sbernauer commented Nov 22, 2024

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/22/

@sbernauer sbernauer changed the title refactor: Move oidc config creation to oidc.rs fix: Calculation of OIDC endpoint Nov 22, 2024
@sbernauer sbernauer changed the title fix: Calculation of OIDC endpoint fix: Calculation of OIDC endpoint when rootPath has no trailing slash Nov 22, 2024
@sbernauer sbernauer self-assigned this Nov 22, 2024
@sbernauer
Copy link
Member Author

sbernauer commented Nov 22, 2024

https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/23 passed :)

This was referenced Nov 22, 2024
Merged
Merged
@sbernauer sbernauer requested review from a team and labrenbe November 25, 2024 06:42
@sbernauer
Copy link
Member Author

sbernauer commented Nov 25, 2024

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/26/

Techassi
Techassi requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of small suggestions and notes. Note that some of these comments most likely also apply to other PRs listed in stackabletech/operator-rs#910.

sbernauer and others added 2 commits November 25, 2024 09:55
@sbernauer @Techassi
Apply suggestions from code review
07f963f 
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer
fix compilation
8cfca69
@sbernauer sbernauer changed the title fix: Calculation of OIDC endpoint when rootPath has no trailing slash fix: Construction of OIDC endpoint when rootPath has no trailing slash Nov 25, 2024
@sbernauer sbernauer requested a review from Techassi November 25, 2024 09:15
Techassi
Techassi reviewed Nov 25, 2024
View reviewed changes
@sbernauer sbernauer added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit c851f51 Nov 25, 2024
@sbernauer sbernauer deleted the fix/oidc-endpoint branch November 25, 2024 10:05
@siegfriedweber siegfriedweber mentioned this pull request Nov 25, 2024
Merged
@lfrancke
Copy link
Member

lfrancke commented Dec 4, 2024

Did this make it into 24.11?

@sbernauer
Copy link
Member Author

sbernauer commented Dec 4, 2024

Nope, but it will be part of 24.11.1. Not sure what label we should use here ^^

@lfrancke
Copy link
Member

lfrancke commented Dec 5, 2024

I think we should add a snippet to the 24.11.1 release notes for this (one entry for all of the affacted ones). Could you add a snippet here?

@sbernauer
Copy link
Member Author

sbernauer commented Dec 12, 2024

Added a snippet to the tracking PR: stackabletech/operator-rs#910 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

@labrenbe labrenbe Awaiting requested review from labrenbe

Assignees

@sbernauer sbernauer

Labels

release/24.11.1

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OIDC AuthenticationClass cannot be shared with other products

3 participants

@sbernauer @lfrancke @Techassi