Skip to content

fix: Re-create shared internal secret with a new name #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labrenbe merged 1 commit into from
Jul 17, 2024
Merged

fix: Re-create shared internal secret with a new name #590

labrenbe merged 1 commit into from
Jul 17, 2024

Conversation

@labrenbe
Copy link
Member

@labrenbe labrenbe commented Jul 16, 2024 •
edited
Loading

Description

Re-creating immutable secrets with the same name is error-prone, because of caching mechanisms internal to kubernetes (see kubernetes/website#42359 (comment)). Deleting the immutable secret and re-creating it with a new name fixes this problem.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape mentioned this pull request Jul 17, 2024
Closed
@NickLarsenNZ NickLarsenNZ mentioned this pull request Jul 17, 2024
Closed
67 tasks
dervoeti
dervoeti approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and tested the fix locally, looks good to me!

@labrenbe labrenbe marked this pull request as ready for review July 17, 2024 09:01
@labrenbe labrenbe added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 07bbbf9 Jul 17, 2024
@labrenbe labrenbe deleted the fix/internal-secret-migration branch July 17, 2024 09:03
@labrenbe labrenbe mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dervoeti dervoeti dervoeti approved these changes

Assignees

No one assigned

Labels

release/24.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labrenbe @dervoeti @xeniape