Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Aug 7, 2024

Description

  • Revert bad release.yml workflow from ci(release): Various workflow fixes #790.
    • The digest is empty, even after push (works on my machine though).
    • I have decided not to update it in this PR, as it can be improved when it uses the reusable actions. Mostly because some variable names were used that have different meanings, and it would be an easy place for errors to creep in.
  • Revert bad publish-image action from ci(release): Various workflow fixes #790.
    • The digest is empty, even after push (works on my machine though).
  • Revert debug change from ci(dev/airflow): debug airflow workflow #800
  • Extract repo digest from structured data (for the publish-image action).
    • It is only available after push
  • Extract repo digest from structured data (for the publish-manifest action).
    • It might only be available after push
    • Uses docker buildx imagetools inspect to get the digest. I checked that it matched when doing this process locally.
🔴 → 🟢

image

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@NickLarsenNZ NickLarsenNZ self-assigned this Aug 7, 2024
@NickLarsenNZ NickLarsenNZ changed the title ci: fix workflows ci(dev): Extract digests from structured output Aug 7, 2024
@NickLarsenNZ
Copy link
Member Author

Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, LGTM overall!

Co-authored-by: Lukas Voetmand <lukas.voetmand@stackable.tech>
@NickLarsenNZ NickLarsenNZ requested a review from dervoeti August 8, 2024 08:06
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 056274f Aug 8, 2024
@NickLarsenNZ NickLarsenNZ deleted the fix/workflows branch August 8, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants