-
-
Notifications
You must be signed in to change notification settings - Fork 6
ci(release): Various workflow fixes #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@dervoeti will review as well |
|
When I build an image locally with bake, push it and then run |
|
I would have to look into the Digest meaning. When I ran it, it was the same as the remote, and I never saw arrays of digests, only the final. Maybe for now, I can keep it the current way, and just print the output of this command (or even compare it), and we can check it over time to see if it matched. |
|
Sounds good! Just want to make sure that we use the correct digest, otherwise signings / SBOMs will break for new builds. If it's the same digest then it's fine for me, printing the digests to compare them sounds like a good next step. I just remembered that I saw some differences when I tried it that way, but that was about a year ago, things might have changed. |
|
On second thought @dervoeti, I'd like to keep my change. I took another look, and it appears to be fine (see explanation below). We are also a while away from the next release, so doing this earlier gives us plenty of time to fix any issues that might appear. ExplanationThe digest used to come from the last line of this output (STDOUT): This matches what I get from: This doesn't work at all: |
|
Yep okay, fine with me. Maybe we can run the build once with the new workflow for one of the images? For example: https://github.com/stackabletech/docker-images/actions/workflows/dev_opa.yaml?query=branch%3Afixes-for-the-jilted-generation |
dervoeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll check some signatures and SBOMs after the builds are done to verify it works as intended.
Uh oh!
There was an error while loading. Please reload this page.