Merged
Conversation
- The enumerate-product-versions.py would not work because it can't find the module "conf" since it was moved to the .scripts subfolder - Changes the release workflow to fail when the enumerate script fails. It used to just swallow the error
NickLarsenNZ
previously approved these changes
Jul 23, 2024
NickLarsenNZ
approved these changes
Jul 24, 2024
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Still don't like the sys.path thing not being CWD, but that can be fixed later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The enumerate-product-versions.py would not work because it can't find the module "conf" since it was moved to the .scripts subfolder
Changes the release workflow to fail when the enumerate script fails. It used to just swallow the error