Skip to content

Remove the deprecated pod enrichment controller - #321

Merged
nightkr merged 5 commits into
mainfrom
chore/drop-pod-enrichment
Jan 22, 2025
Merged

Remove the deprecated pod enrichment controller#321
nightkr merged 5 commits into
mainfrom
chore/drop-pod-enrichment

Conversation

@nightkr

@nightkr nightkr commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #292

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr

nightkr commented Jan 22, 2025

Copy link
Copy Markdown
Contributor Author

Release note:

Pod enrichment [FIXME: change this to /24.11 in the actual release notes] has now been removed, after being deprecated in 24.11. Remaining users are encouraged to migrate to the Stackable Listener Operator instead, which makes fewer assumptions around how the Pod should be accessed.

@nightkr
nightkr requested a review from a team January 22, 2025 14:07
sbernauer
sbernauer previously approved these changes Jan 22, 2025
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only on minor nit

Comment thread docs/modules/commons-operator/pages/index.adoc Outdated
@nightkr @sbernauer
Update docs/modules/commons-operator/pages/index.adoc
00ce870 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@nightkr
nightkr requested a review from sbernauer January 22, 2025 14:28
@nightkr
nightkr enabled auto-merge January 22, 2025 14:28
sbernauer
sbernauer previously approved these changes Jan 22, 2025
View reviewed changes
@sbernauer

sbernauer commented Jan 22, 2025

Copy link
Copy Markdown
Member

@nightkr watch out, pre-commit failed

@nightkr
nightkr added this pull request to the merge queue Jan 22, 2025
@nightkr
nightkr removed this pull request from the merge queue due to a manual request Jan 22, 2025
@nightkr

nightkr commented Jan 22, 2025

Copy link
Copy Markdown
Contributor Author

Goddamnit.. fixed.

@nightkr
nightkr enabled auto-merge January 22, 2025 14:43
@nightkr
nightkr requested a review from sbernauer January 22, 2025 14:43
sbernauer
sbernauer approved these changes Jan 22, 2025
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nightkr
nightkr added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit ef430d1 Jan 22, 2025
@nightkr
nightkr deleted the chore/drop-pod-enrichment branch January 22, 2025 14:58
Techassi added a commit that referenced this pull request Jan 27, 2025
@Techassi
docs: Fix unterminated table
a33e138 
The faulty change was introduced in 4b14f04 for PR #321. Came up in
stackabletech/documentation#703.
Techassi added a commit that referenced this pull request Jan 27, 2025
@Techassi
docs: Fix unterminated table
e2ae76c 
The faulty change was introduced in 4b14f04 for PR #321. Came up in
stackabletech/documentation#703.
@Techassi Techassi mentioned this pull request Jan 27, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jan 27, 2025
@Techassi
docs: Fix unterminated table (#323)
a3333a0 
The faulty change was introduced in 4b14f04 for PR #321. Came up in
stackabletech/documentation#703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop pod enrichment controller

2 participants

@nightkr @sbernauer