Skip to content

Prevent double logging of the airflow container logs #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siegfriedweber merged 4 commits into from
Jul 23, 2024
Merged

Prevent double logging of the airflow container logs #474

siegfriedweber merged 4 commits into from
Jul 23, 2024

Conversation

@siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jul 19, 2024 •
edited
Loading

Description

Prevent double logging of the airflow container logs

Both executors are now tested in the logging test.

Fixes #473

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber requested a review from a team July 19, 2024 14:10
@siegfriedweber siegfriedweber self-assigned this Jul 19, 2024
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jul 19, 2024 •
edited
Loading

❌ https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/3/

NickLarsenNZ
NickLarsenNZ reviewed Jul 19, 2024
View reviewed changes
NickLarsenNZ
NickLarsenNZ previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I am not so familiar with the aggregator rules.

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jul 22, 2024 •
edited
Loading

❌ https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/4/

@lfrancke lfrancke mentioned this pull request Jul 23, 2024
Closed
67 tasks
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jul 23, 2024 •
edited
Loading

✅ https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/5/

@siegfriedweber siegfriedweber requested review from a team and NickLarsenNZ July 23, 2024 09:19
NickLarsenNZ
NickLarsenNZ approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber siegfriedweber enabled auto-merge July 23, 2024 10:36
@siegfriedweber siegfriedweber added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 6b54879 Jul 23, 2024
@siegfriedweber siegfriedweber deleted the fix/logging branch July 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

release/24.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logs from the airflow container are logged twice

3 participants

@siegfriedweber @NickLarsenNZ @lfrancke