Skip to content

refactor(app): deprecate flat API and flatten runtime context - #533

Draft
meganetaaan wants to merge 2 commits into
developfrom
refactor/issue-512-runtime-context
Draft

refactor(app): deprecate flat API and flatten runtime context#533
meganetaaan wants to merge 2 commits into
developfrom
refactor/issue-512-runtime-context

Conversation

@meganetaaan

@meganetaaan meganetaaan commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

概要

StackchanRuntimeContext の flat compat API に deprecation を付け、capability wrapper の不要な間接呼び出しを整理します。

変更内容

  • StackchanLegacyFlatCapability と flat member に @deprecated JSDoc を追加
  • capability wrapper を runtime / service へ直接委譲
  • NetworkReadyResult を capabilities.ts に一本化
  • void this.#updateFaceHandler を削除
  • docs を namespaced API を primary とする表記に更新

互換性

公開 API shape は維持します。flat API は削除せず、deprecated annotation のみ追加しています。

検証

  • cd firmware && npm run lint: pass
  • cd firmware && npm run test:unit: pass, 31 tests
  • cd firmware && npm run check:architecture: pass, 13 tests
  • cd firmware && npm run check:legacy-names: pass
  • git diff --check: pass

未実施

  • 実機確認
  • test:moddable / build

リリース影響

patch。互換 API は維持しますが、deprecation 告知はリリースノート記載推奨です。

Closes #512
関連 #392 #515

🤖 Generated with Claude Code

@meganetaaan @claude
refactor(app): deprecate flat API and flatten runtime context
8db1fa7 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 74305302-6837-4617-9d68-18775611baba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/issue-512-runtime-context

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@meganetaaan

meganetaaan commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@meganetaaan

meganetaaan commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StackchanRuntimeContext の整理(フラット互換APIの非推奨化と責務分割)

1 participant

@meganetaaan