Skip to content

fix team invites #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BilalG1 merged 7 commits into from
Nov 5, 2025
Merged

fix team invites #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efbb81c
fix team invites
BilalG1 Oct 31, 2025
c58bb21
Merge dev into fix-team-invites
N2D4 Oct 31, 2025
8b1bad4
Merge dev into fix-team-invites
N2D4 Nov 4, 2025
a46700b
Merge dev into fix-team-invites
N2D4 Nov 5, 2025
ac7bf4c
validate callback url
BilalG1 Nov 5, 2025
2f7a67e
Merge branch 'dev' into fix-team-invites
BilalG1 Nov 5, 2025
b3d6a93
add test to ensure untrusted callbacks error
BilalG1 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/dashboard/src/app/(main)/(protected)/(outside-dashboard)/projects/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export async function listInvitations(teamId: string) {
}));
}

export async function inviteUser(teamId: string, email: string, callbackUrl: string) {
export async function inviteUser(teamId: string, email: string, origin: string) {
const callbackUrl = new URL(stackServerApp.urls.teamInvitation, origin).toString();
const user = await stackServerApp.getUser();
const team = await user?.getTeam(teamId);
if (!team) {
Expand Down
30 changes: 30 additions & 0 deletions apps/e2e/tests/backend/endpoints/api/v1/team-invitations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,3 +525,33 @@ it("errors with item_quantity_insufficient_amount when accepting invite without
}
`);
});

it("should error when untrusted callback URL is provided", async ({ expect }) => {
const { teamId } = await Team.create();
const receiveMailbox = createMailbox();

backendContext.set({ userAuth: null });
const sendTeamInvitationResponse = await niceBackendFetch("/api/v1/team-invitations/send-code", {
method: "POST",
accessType: "server",
body: {
email: receiveMailbox.emailAddress,
team_id: teamId,
callback_url: "https://malicious.com/callback",
},
});

expect(sendTeamInvitationResponse).toMatchInlineSnapshot(`
NiceResponse {
"status": 400,
"body": {
"code": "REDIRECT_URL_NOT_WHITELISTED",
"error": "Redirect URL not whitelisted. Did you forget to add this domain to the trusted domains list on the Stack Auth dashboard?",
},
"headers": Headers {
"x-stack-known-error": "REDIRECT_URL_NOT_WHITELISTED",
<some fields may have been hidden>,
},
}
`);
});