Analysis

Unhandled exception in Result.retry() for svix.messageAttempt.listByMsg() call

What fails: The svix.messageAttempt.listByMsg() call in send-test-webhook route handler (line 79-82) is not wrapped in Result.fromPromise(), causing unhandled exceptions to escape the retry logic

How to reproduce:

1. Trigger webhook test with network failure or API rate limiting
2. Svix client throws exception (e.g., network timeout, rate limit)
3. Exception propagates out of Result.retry() function instead of being caught and retried

Result: Route handler crashes with unhandled promise rejection instead of graceful error handling. Retry logic bypassed completely.

Expected: All exceptions should be converted to Result.error() via Result.fromPromise() wrapper, allowing retry logic to handle failures properly (consistent with other Svix calls in same file at lines 35 and 48)

Evidence: Result.retry() function signature expects (attemptIndex: number) => Result<T> | Promise<Result<T>> but current code calls async function that can throw exceptions directly

Analysis

Unhandled exception in send-test-webhook route causes 500 errors

What fails: svix.application.getOrCreate() in /apps/backend/src/app/api/latest/internal/send-test-webhook/route.tsx:34 throws ApiException when Svix API calls fail, crashing the route handler

How to reproduce:

// Trigger with invalid Svix credentials or network issues
const svix = new Svix('invalid-api-key');
await svix.application.getOrCreate({ uid: 'test-project', name: 'test-project' });

Result: Throws ApiException with HTTP 401/network errors, causing route handler to return 500 instead of graceful error response

Expected: Should return structured error response like other Svix calls in the same file (lines 35, 48) that use Result.fromPromise()

diff --git a/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx b/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
index b34fe218..cdea27fe 100644
--- a/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
+++ b/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
@@ -258,6 +258,7 @@ function TestEndpointDialog(props: { endpoint: Endpoint, open: boolean, onOpenCh
           await sendTestEvent();
           return 'prevent-close';
         },
+        props: { disabled: status === 'sending' }
       }}
       cancelButton={status === 'sending' ? false : { label: 'Cancel' }}
     >

Analysis

"Send test event" button allows multiple concurrent webhook API calls

What fails: TestEndpointDialog okButton remains enabled during async sendTestEvent() operation (status === 'sending'), allowing multiple simultaneous API requests

How to reproduce:

1. Open webhook test dialog in dashboard
2. Click "Send test event" button rapidly multiple times before first request completes
3. Multiple API calls to stackAdminApp.sendTestWebhook() execute concurrently

Result: Multiple identical webhook test requests sent simultaneously instead of button being disabled during operation

Expected: Button should be disabled during sending state, consistent with cancelButton behavior which hides when status === 'sending'

Fix: Added props: { disabled: status === 'sending' } to okButton configuration, following existing pattern used elsewhere in codebase for disabled buttons

diff --git a/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx b/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
index b34fe218..55705902 100644
--- a/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
+++ b/apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
@@ -16,7 +16,7 @@ import { AppEnabledGuard } from "../app-enabled-guard";
 import { PageLayout } from "../page-layout";
 import { useAdminApp } from "../use-admin-app";
 import { getSvixResult } from "./utils";
-import { runAsynchronously } from "@stackframe/stack-shared/dist/utils/promises";
+import { runAsynchronouslyWithAlert } from "@stackframe/stack-shared/dist/utils/promises";
 
 type Endpoint = {
   id: string,
@@ -114,7 +114,7 @@ function CreateDialog(props: {
       ) : (
         <Form {...form}>
           <form
-            onSubmit={(e) => runAsynchronously(handleSubmit(e))}
+            onSubmit={(e) => runAsynchronouslyWithAlert(handleSubmit(e))}
             className="space-y-4"
           >
             <Alert>

Analysis

Silent error handling in webhook endpoint creation leaves users without feedback

What fails: CreateDialog in apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx uses runAsynchronously() which catches svix.endpoint.create() errors but doesn't show them to users

How to reproduce:

1. Navigate to webhook settings page
2. Click "Create new endpoint"
3. Enter invalid URL or trigger network failure
4. Click "Create" button

Result: Form submission fails silently - errors logged to console but user sees no feedback, form remains in normal state

Expected: Error should be displayed to user via alert (like other forms) so they know endpoint creation failed

Fix applied: Changed runAsynchronously() to runAsynchronouslyWithAlert() to match pattern used in new-project creation and provide user error feedback

diff --git a/apps/backend/src/app/api/latest/internal/send-test-webhook/route.tsx b/apps/backend/src/app/api/latest/internal/send-test-webhook/route.tsx
index c0b42dc7..26b4f6d9 100644
--- a/apps/backend/src/app/api/latest/internal/send-test-webhook/route.tsx
+++ b/apps/backend/src/app/api/latest/internal/send-test-webhook/route.tsx
@@ -75,7 +75,7 @@ export const POST = createSmartRouteHandler({
       };
     }
 
-    const attemptResult = await Result.retry(async () => {
+    const attemptResult = await Result.retry(async (_attemptIndex) => {
       const attempts = await svix.messageAttempt.listByMsg(
         projectId,
         messageResult.data.id,
diff --git a/apps/backend/src/lib/webhooks.tsx b/apps/backend/src/lib/webhooks.tsx
index cac56608..f6820c2d 100644
--- a/apps/backend/src/lib/webhooks.tsx
+++ b/apps/backend/src/lib/webhooks.tsx
@@ -46,7 +46,7 @@ async function sendWebhooks(options: {
 
 function createWebhookSender<T extends yup.Schema>(event: WebhookEvent<T>) {
   return async (options: { projectId: string, data: yup.InferType<typeof event.schema> }) => {
-    await Result.retry(async () => {
+    await Result.retry(async (_attemptIndex) => {
       try {
         return Result.ok(await sendWebhooks({
           type: event.type,

Analysis

Missing required parameter in Result.retry callback functions

What fails: Result.retry function calls in send-test-webhook/route.tsx:78 and webhooks.tsx:49 pass callback functions with no parameters, but the function signature requires (attemptIndex: number) => Result<T>

How to reproduce:

# TypeScript compilation should catch this with --strict mode:
cd apps/backend && pnpm run typecheck

Result: TypeScript parameter count mismatch error (function expects 1 parameter but receives 0)

Expected: Callback functions should declare the attemptIndex parameter per the TypeScript function signature - use _attemptIndex if not needed (matching pattern used elsewhere in codebase)