apps/backend/prisma/migrations/20260210120000_session_recordings_mvp/migration.sql (1)

52-53: Unique index name is misleading — it omits tenancyId from the name despite including it in the columns.

The index SessionRecordingChunk_sessionRecordingId_batchId_key actually covers (tenancyId, sessionRecordingId, batchId). Consider renaming it to SessionRecordingChunk_tenancyId_sessionRecordingId_batchId_key to match the Prisma-generated naming convention and avoid confusion during debugging.

Suggested rename

-CREATE UNIQUE INDEX "SessionRecordingChunk_sessionRecordingId_batchId_key"
+CREATE UNIQUE INDEX "SessionRecordingChunk_tenancyId_sessionRecordingId_batchId_key"
   ON "SessionRecordingChunk"("tenancyId", "sessionRecordingId", "batchId");

apps/backend/prisma/schema.prisma (1)

283-305: refreshTokenId has no FK constraint to ProjectUserRefreshToken.

refreshTokenId is stored as a plain UUID without a foreign key relation. If a refresh token is revoked or deleted, this becomes a dangling reference. If this is intentional (to preserve recording metadata after token cleanup), a brief comment explaining the design choice would be helpful for future readers.

apps/backend/src/s3.tsx (1)

63-88: Add comments explaining the as any casts per coding guidelines.

The duck-typing checks here require as any because the AWS SDK v3 Body type is StreamingBlobPayloadOutputTypes | undefined, a complex union that doesn't expose transformToByteArray or Symbol.asyncIterator in its static type. A short comment on each cast would satisfy the project's guideline. As per coding guidelines: "Try to avoid the any type. When using any, leave a comment explaining why it's being used."

Suggested comments

   // Web ReadableStream (some runtimes)
+  // `any` cast: AWS SDK v3 Body is a complex union; `transformToByteArray` is a SdkStreamMixin method not visible in all type overlaps.
   if (typeof body === "object" && body !== null && "transformToByteArray" in body && typeof (body as any).transformToByteArray === "function") {
     return (body as any).transformToByteArray();
   }
 
   // Node.js Readable or any AsyncIterable<Uint8Array>
+  // `any` cast: Symbol.asyncIterator is not in the static Body type union from AWS SDK.
   if (typeof body === "object" && body !== null && Symbol.asyncIterator in (body as any)) {
     const chunks: Buffer[] = [];
     for await (const chunk of body as any) {

apps/backend/prisma/seed.ts (1)

1819-1819: Prefer ?? throwErr(...) over the non-null assertion.

Even though userIds is verified non-empty on line 1804, the coding guidelines prefer defensive coding over !.

Suggested fix

-    const projectUserId = userIds[Math.floor(Math.random() * userIds.length)]!;
+    const projectUserId = userIds[Math.floor(Math.random() * userIds.length)] ?? throwErr('userIds index out of bounds');

As per coding guidelines: "Code defensively. Prefer ?? throwErr(...) over non-null assertions with good error messages explicitly stating the assumption that must've been violated."

apps/backend/src/app/api/latest/session-recordings/batch/route.tsx (1)

22-29: Add a comment explaining the as any cast.

e is typed as unknown from the unknown[] parameter, so the cast is unavoidable, but the coding guidelines ask for a comment. As per coding guidelines: "Try to avoid the any type. When using any, leave a comment explaining why it's being used."

Suggested fix

     if (!("timestamp" in e)) continue;
+    // `any` cast: events are untyped rrweb payloads; we duck-type check for `timestamp` above.
     const ts = (e as any).timestamp;