Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughReplaced a framework-specific test-environment check with a Node.js NODE_ENV-based check in the OAuth client interface; removed the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/stack-shared/src/interface/client-interface.ts`:
- Around line 1043-1044: The comment above the allowInsecure declaration is
inaccurate: it says "only in test environment" while the code uses
process.env.NODE_ENV !== 'production' so insecure HTTP is permitted in any
non-production environment; update the comment to accurately reflect this
behavior (referencing the allowInsecure constant, tokenEndpoint check, and
NODE_ENV) — e.g., note that insecure HTTP is allowed when NODE_ENV is not
'production' and tokenEndpoint starts with 'http://', rather than "test
environment" only.
Contributor
Greptile SummaryFixed sign-in bug in development environment by updating the insecure HTTP check for OAuth token endpoints.
The original code only allowed insecure HTTP requests (localhost testing) when Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant App as Application
participant Interface as StackClientInterface
participant Library as OAuth4WebAPI
participant Server as API Server
Note over App,Server: Token Refresh Flow
App->>Interface: Request token refresh
Interface->>Interface: Evaluate environment setting
alt Not in production
Interface->>Library: Grant request (insecure allowed)
else In production
Interface->>Library: Grant request (secure only)
end
Library->>Server: Token request
Server-->>Library: Response
Library-->>Interface: Token data
Interface-->>App: Access token
Note over App,Server: Callback flow uses same logic
|
N2D4
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/stack-shared/src/interface/client-interface.ts`:
- Line 168: The current expression for allowInsecure uses
process.env.NODE_ENV.includes(...) which can be undefined and causes TS/runtime
errors; normalize NODE_ENV first (e.g., const env = String(process.env.NODE_ENV
|| '') or process.env.NODE_ENV ?? '') and then replace occurrences so
allowInsecure is computed using env.includes('dev') and env === 'test' with
tokenEndpoint.startsWith('http://'); update any other sites (e.g., the other
occurrence around line 1044) to use the same normalized env variable to avoid
TS18048 and runtime crashes.
♻️ Duplicate comments (1)
packages/stack-shared/src/interface/client-interface.ts (1)
1043-1044: Update the comment to reflect dev/test behavior.The comment says “test environment only,” but the condition also allows dev. Align the comment with the actual logic.
📝 Suggested comment update
- // Allow insecure HTTP requests only in test environment (for localhost testing) + // Allow insecure HTTP requests in dev/test environments (for localhost testing) const allowInsecure = (process.env.NODE_ENV.includes("dev") || process.env.NODE_ENV === 'test') && tokenEndpoint.startsWith('http://');
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
N2D4
pushed a commit
that referenced
this pull request
Jan 19, 2026
<!-- Make sure you've read the CONTRIBUTING.md guidelines: https://github.com/stack-auth/stack-auth/blob/dev/CONTRIBUTING.md --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Updated internal environment detection mechanism for OAuth flows. Insecure HTTP requests are now allowed when running outside of production environments, rather than only during testing scenarios. No changes to public APIs. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.