Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR consolidates Convex authentication integration improvements by establishing new public export paths ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-11-25T02:09:03.086ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile OverviewGreptile SummaryReplaced dynamic imports with static imports for
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant ServerApp as server-app-impl.ts
participant SimpleWebAuthn as @simplewebauthn/browser
participant API as Stack API
Note over ServerApp: Static imports now used<br/>instead of dynamic imports
User->>ServerApp: Request passkey registration
ServerApp->>API: Get initiation options
API-->>ServerApp: Return options_json + code
ServerApp->>ServerApp: Override rpID with hostname
ServerApp->>SimpleWebAuthn: startRegistration(optionsJSON)
alt Success
SimpleWebAuthn-->>ServerApp: Return attestation response
ServerApp->>API: Complete registration
else WebAuthnError
SimpleWebAuthn-->>ServerApp: WebAuthnError
ServerApp-->>User: PasskeyWebAuthnError
else Unknown Error
SimpleWebAuthn-->>ServerApp: Unknown error
ServerApp->>ServerApp: captureError()
ServerApp-->>User: PasskeyRegistrationFailed
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/template/src/lib/stack-app/apps/implementations/server-app-impl.ts(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-11T04:13:19.308Z
Learnt from: N2D4
Repo: stack-auth/stack-auth PR: 943
File: examples/convex/app/action/page.tsx:23-28
Timestamp: 2025-10-11T04:13:19.308Z
Learning: In the stack-auth codebase, use `runAsynchronouslyWithAlert` from `stackframe/stack-shared/dist/utils/promises` for async button click handlers and form submissions instead of manual try/catch blocks. This utility automatically handles errors and shows alerts to users.
Applied to files:
packages/template/src/lib/stack-app/apps/implementations/server-app-impl.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: restart-dev-and-test-with-custom-base-port
- GitHub Check: check_prisma_migrations (22.x)
- GitHub Check: restart-dev-and-test
- GitHub Check: all-good
- GitHub Check: Vercel Agent Review
- GitHub Check: setup-tests
🔇 Additional comments (1)
packages/template/src/lib/stack-app/apps/implementations/server-app-impl.ts (1)
16-16: Hooking unknown passkey failures intocaptureErrorlooks goodWiring the non‑
WebAuthnErrorbranch ofregisterPasskeythroughcaptureErrorintegrates these “should never happen” failures with the central error pipeline without changing behavior for known error types; no issues from my side.
packages/template/src/lib/stack-app/apps/implementations/server-app-impl.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/dashboard/package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Dev Environment Test
apps/dashboard/package.json
[warning] 1-1: The field "pnpm.overrides" was found in /home/runner/work/stack-auth/stack-auth/apps/dashboard/package.json. This will not take effect. You should configure "pnpm.overrides" at the root of the workspace instead.
🪛 GitHub Actions: Dev Environment Test With Custom Base Port
apps/dashboard/package.json
[warning] 1-1: pnpm.overrides field found in apps/dashboard/package.json. This will not take effect. Configure "pnpm.overrides" at the root of the workspace instead.
🪛 GitHub Actions: Ensure Prisma migrations are in sync with the schema
apps/dashboard/package.json
[warning] 1-1: The field "pnpm.overrides" was found in /home/runner/work/stack-auth/stack-auth/apps/dashboard/package.json. This will not take effect. You should configure "pnpm.overrides" at the root of the workspace instead.
🪛 GitHub Actions: Lint & build
apps/dashboard/package.json
[warning] 1-1: pnpm.overrides field found in package.json will not take effect in CI. Configure pnpm.overrides at the root of the workspace.
🪛 GitHub Actions: Run setup tests
apps/dashboard/package.json
[warning] 1-1: The field 'pnpm.overrides' was found in this package.json. This will not take effect. Configure 'pnpm.overrides' at the root of the workspace instead.
🪛 GitHub Actions: Runs E2E API Tests
apps/dashboard/package.json
[warning] 1-1: pnpm.overrides field is present but will not take effect. Configure 'pnpm.overrides' at the root of the workspace.
[error] 1-1: pnpm install --frozen-lockfile failed: lockfile is not up to date with manifests. specifiers in the lockfile don't match specifiers in package.json: next (lockfile: 16.0.2-canary.33, manifest: 16.0.0). Run 'pnpm install' without --frozen-lockfile or update the lockfile.
🪛 GitHub Actions: Runs E2E API Tests with custom port prefix
apps/dashboard/package.json
[warning] 1-1: The field "pnpm.overrides" was found in /home/runner/work/stack-auth/stack-auth/apps/dashboard/package.json. This will not take effect. You should configure "pnpm.overrides" at the root of the workspace instead.
🪛 GitHub Actions: Runs E2E API Tests with external source of truth
apps/dashboard/package.json
[warning] 1-1: The field "pnpm.overrides" was found in package.json. This will not take effect. You should configure "pnpm.overrides" at the root of the workspace instead.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Vercel Agent Review
- GitHub Check: all-good
🔇 Additional comments (2)
apps/dashboard/package.json (2)
1-89: Missing PR context: Clarify the "convex bundle bug" and scope of changes.The PR description is empty (only a template comment). The AI summary mentions changes to SimpleWebAuthn imports in
packages/template/src/lib/stack-app/apps/implementations/server-app-impl.ts, but onlyapps/dashboard/package.jsonis provided for review. Clarify:
- What is the "convex bundle bug" being fixed?
- Are there other files in this PR (e.g., the SimpleWebAuthn import changes)?
- Why does fixing a convex/bundle bug require downgrading the Next.js version?
This information is essential for a comprehensive review.
49-49: Confirm Next.js 16.0.0 compatibility and verify migration of breaking changes.Next.js 16.0.0 is compatible with React 19.2.0 and explicitly supports React 19 features. The stable version exists and addresses modern dependency requirements.
However, Next.js 16 introduces major breaking changes: async-only Dynamic Request APIs (cookies(), headers(), draftMode(), params, searchParams must be awaited), minimum Node.js >= 20.9.0, TypeScript >= 5.1.0, and removal of AMP support and next lint command. Before merging:
- Verify the codebase handles async Request API migrations (use provided Next.js codemods).
- Confirm project meets Node.js ≥ 20.9.0 and TypeScript ≥ 5.1.0.
- Review impact of Turbopack becoming the default bundler and image config changes.
- Clarify the "convex bundle bug" rationale for this version change.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/e2e/tests/general/examples.test.ts(1 hunks)examples/convex/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/e2e/tests/general/examples.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Vercel Agent Review
- GitHub Check: build (22.x)
- GitHub Check: all-good
- GitHub Check: lint_and_build (latest)
- GitHub Check: restart-dev-and-test
- GitHub Check: check_prisma_migrations (22.x)
- GitHub Check: build (22.x)
- GitHub Check: setup-tests
- GitHub Check: restart-dev-and-test-with-custom-base-port
- GitHub Check: build (22.x)
- GitHub Check: docker
BilalG1
force-pushed
the
convex-fix-bug
branch
from
17afae4 to
9c87a5f
Compare
2 participants
Summary by CodeRabbit
New Features
./convex/authacross multiple packages for new module resolution optionsconvex:checkto example projectDocumentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.