packages/template/src/lib/cookie.ts (1)

205-210: LGTM! Secure flag now properly included in cookie deletion.

The addition of secure: determineSecureFromClientContext() ensures cookies are deleted with the same security attributes they were set with, which is required by browser cookie APIs. This aligns with how setCookieClientInternal (line 197) sets cookies based on the secure context.

Optional: Cache the secure context value.

Since determineSecureFromClientContext() is called twice (lines 207 and 209), consider caching the result:

 function deleteCookieClientInternal(name: string, options: DeleteCookieOptions = {}) {
+  const secure = determineSecureFromClientContext();
   if (options.domain !== undefined) {
-    Cookies.remove(name, { domain: options.domain, secure: determineSecureFromClientContext() });
+    Cookies.remove(name, { domain: options.domain, secure });
   }
-  Cookies.remove(name, { secure: determineSecureFromClientContext() });
+  Cookies.remove(name, { secure });
 }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/e2e/tests/js/cookies.test.ts (2)

172-172: Rename variable to reflect it stores the custom cookie value.

The variable defaultValue stores the value from customCookieName, which is misleading.

Apply this diff:

- const defaultValue = cookieStore.get(customCookieName)!;
+ const customValue = cookieStore.get(customCookieName)!;
- const parsedValue = JSON.parse(decodeURIComponent(defaultValue));
+ const parsedValue = JSON.parse(decodeURIComponent(customValue));

---

185-185: Consider checking expires attribute on the specific custom cookie.

The assertion checks if any refresh cookie has an expires attribute but doesn't verify it's specifically the custom cookie. Since you already extract customAttrs on line 183, consider adding a specific check there.

Example:

  const customAttrs = findCookieAttributes(cookieWrites, customCookieName);
  expect(customAttrs?.get("domain")).toBe("example.com");
+ expect(customAttrs?.has("expires")).toBe(true);
- expect(cookieWrites.some((entry) => entry.toLowerCase().startsWith("stack-refresh-") && entry.toLowerCase().includes("expires="))).toBe(true);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro