Greptile Overview

Greptile Summary

Fixed a control flow bug in _queueCustomRefreshCookieUpdate where the server-side hostname lookup was unconditionally overwriting the browser hostname. The bug was introduced in PR #971 when the Next.js platform-specific code wasn't wrapped in an else block, causing the server's sc.headers() call to always execute and override window.location.hostname even in browser contexts.

Key changes:

• Added else block around Next.js server hostname retrieval (line 593-595)
• Added warning log when hostname cannot be determined (line 598)

This ensures proper hostname detection for cookie domain configuration in both browser and Next.js server environments.

Confidence Score: 5/5

• This PR is safe to merge - it fixes a critical control flow bug with a minimal, surgical change
• The fix addresses a clear logic error where server code was executing in browser context, overwriting the correct hostname value. The change is minimal (adding one else block), follows the platform conditional pattern used elsewhere in the codebase, and adds helpful debugging with the console.warn. No security issues or unintended side effects introduced.
• No files require special attention

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant App as Client App
    participant Func as _queueCustomRefreshCookieUpdate
    participant Browser as Browser Check
    participant Server as Next.js Server (sc.headers)
    participant Cache as _trustedParentDomainCache
    participant Cookie as setCookie

    App->>Func: Call with refreshToken, updatedAt, context
    Func->>Browser: isBrowserLike()?
    
    alt Browser Environment
        Browser-->>Func: true
        Func->>Func: hostname = window.location.hostname
    else Server Environment (Next.js)
        Browser-->>Func: false
        Func->>Server: await sc.headers().get("host")
        Server-->>Func: hostname from headers
    end
    
    alt No hostname found
        Func->>Func: console.warn() and return
    else Hostname found
        Func->>Cache: getOrWait([hostname])
        Cache-->>Func: trusted parent domain
        Func->>Cookie: Set/delete cookie with domain
    end

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}