Replace setuptools_scm with bump2version#793
Merged
brianmay merged 2 commits intosshuttle:masterfrom Sep 4, 2022
Merged
Conversation
venthur
changed the title
brianmay
approved these changes
Aug 29, 2022
Member
brianmay
left a comment
brianmay
left a comment
There was a problem hiding this comment.
LGTM, will leave it a bit longer in case anybody else wants to comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #754, this PR replaces setuptools_scm with
bump2version.You'll notice that
sshuttle/version.pyis now under version control, this is intentional.How to use?
Whenever you want to bump the version just:
or
depending on which part of the version you'll want to bump. This will update the
sshuttle/version.pyand thesetup.cfgand requires a new commit. That's all.I wasn't sure where to add the dependency to
bump2versionso I added it torequirements-test.txt, assuming that this is more correct than therequirements.txt.