Add tests for host name resolution#734
Merged
brianmay merged 7 commits intosshuttle:masterfrom Feb 10, 2022
Merged
Conversation
brianmay
approved these changes
Feb 9, 2022
Member
|
Looks good, but flake8 not happy. Some of the flake8 issues are line length: Am happy to consider increasing the maximum line length if you want. |
Contributor
Author
|
Oops! My bad... Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to touch the subnet option parser (at
options.py).However, I found some test cases for that are missing.
I believe we should test it can parse and resolve host names.
Hope you accept and merge this.
Thank you,