Make --sudoers option work properly, fix regression in v1.1.0#727
Merged
brianmay merged 1 commit intosshuttle:masterfrom Feb 3, 2022
Merged
Make --sudoers option work properly, fix regression in v1.1.0#727brianmay merged 1 commit intosshuttle:masterfrom
brianmay merged 1 commit intosshuttle:masterfrom
Conversation
Commit d6f75fa unintentionally changed the order of some of the parameters when running the firewall process. This prevented the --sudoers option from working properly. This patch restores the previous ordering. Most discussion was in issue sshuttle#724. Also fixes sshuttle#722 and sshuttle#723.
Contributor
Author
|
Correction, this doesn't fix #722 which seems to be more focused on realpath being missing on MacOS. |
This was referenced Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d6f75fa unintentionally changed the order of some of the
parameters when running the firewall process. This prevented the
--sudoers option from working properly. This patch restores the
previous ordering.
Most discussion was in issue #724. Also fixes #722 and #723.