Flush systemd DNS cache on startup and exit.#634
Merged
brianmay merged 1 commit intosshuttle:masterfrom May 18, 2021
Merged
Conversation
It is possible for DNS requests to go through systemd's DNS resolution system (which includes a cache) before sshuttle has an opportunity to intercept the requests. The DNS entries in the cache may become outdated when sshuttle starts or exits. This patch fixes the problem by flushing the cache when sshuttle firewall starts and exits.
brianmay
reviewed
May 17, 2021
Member
brianmay
left a comment
brianmay
left a comment
There was a problem hiding this comment.
In general, have been unahppy integrating systemd stuff directly into the core functionality like this. But I can't think of a better solution, so will probably accept, once you respond to the other feeback I provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for DNS requests to go through systemd's DNS resolution
system (which includes a cache) before sshuttle has an opportunity to
intercept the requests. The DNS entries in the cache may become
outdated when sshuttle starts or exits. This patch fixes the problem
by flushing the cache when sshuttle firewall starts and exits.
This implements a suggestion in #554.