Skip to content

Fix handling OSError in FirewallClient#__init__ #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianmay merged 1 commit into from
Nov 16, 2020
Merged

Fix handling OSError in FirewallClient#__init__ #561

brianmay merged 1 commit into from
Nov 16, 2020

Conversation

@Krout0n
Copy link
Contributor

@Krout0n Krout0n commented Nov 16, 2020 •
edited
Loading

Related: this comment

If we revert this, e will be unbounded. Try the following code.

e = None
try:
    raise OSError
except OSError as e:
    pass
print(e) # Unbounded

So, I make the timing of logging and raising be done in for-iteration.

@brianmay brianmay merged commit ff70f58 into sshuttle:master Nov 16, 2020
@Krout0n Krout0n deleted the fix-handling-OSError branch November 16, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krout0n @brianmay