I think these two lines need fixing also:

Python 2.7 doesn't support the rb string prefix.

Do they get called on the server? I thought that was client side.

My intention was just to patch the server side code for python2 compatibility. Then we might manage to maintain it for a while. Trying keep the whole client python2 compatible seems like too much work.

Either way, I think the 'b' can be safely removed right? Just testing those asserts in python2 and python3 everything seems to work fine as just r-strings. If you agree then I push a change to remove the 'b'.

OK, sounds good to me.

No,unfortunately, you can't remove the b prefix, it will break under python3 because the string is a byte value:

>>> import re
>>> re.search(rb'[^-\w\.]', b'abc')
>>> re.search(r'[^-\w\.]', b'abc')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.8/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: cannot use a string pattern on a bytes-like object

Ah yes, I didn't think about the case the string being searched was byte string. Let me see if I can work around it.

Haha, how about that for a fix! I made a minimal test outside of sshuttle and it seemed to be fine once I switched the order of rb to br! Not sure how to test within sshuttle because I don't think my usage ever hits those lines.

Wow. I never thought of switching it to 'br'. Anyway, thanks for you work here.

Any clue bout when will it be released?

@leiserfg sshuttle 1.0.5 was recently released with this fix.