Change license text to LGPL-2.1#511
Merged
brianmay merged 1 commit intosshuttle:masterfrom Aug 26, 2020
Rylan12:license-update
Merged
Change license text to LGPL-2.1#511brianmay merged 1 commit intosshuttle:masterfrom Rylan12:license-update
brianmay merged 1 commit intosshuttle:masterfrom
Rylan12:license-update
Conversation
Member
|
Good question. For reference this:
It looks like there is a bit of confusion of the copyright in the upstream project. In fact one of the copyright headers looks like a copy and paste from on of my projects (including the project name!). https://github.com/apenwarr/sshuttle/blob/master/setup.py Having said that, I really don't think anybody is going to be upset with this proposed changed. It already has been LGPL2.1+ for almost 3 years in setup.py. Will merge. Thanks. |
Contributor
Author
|
Thanks, @brianmay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, Homebrew maintainer here.
While trying to add license information about
sshuttleto Homebrew (see Homebrew/homebrew-core#60154), we ran into some confusion aboutsshuttle's license.As seen in
setup.py,LGPL-2.1-or-laterseems to be the correct license:sshuttle/setup.py
Lines 7 to 10 in 73eb3b6
However, the
LICENSEfile still contains the text forLGPL-2.0.This PR changes the license text to reflect the
LGPL-2.1license. If it's the other way around (meaning that this should beLGPL-2.0and thesetup.pyheader is incorrect, I would be happy to have this PR make those changes instead).