chore: suppress imp DeprecationWarning #452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this needs a proper fix. I don't think hiding a deprecation warning is the proper fix, it will come around and bite as at a latter date. Sorry, I have no idea how to fix this though, and don't have time to think about it right now. |
Contributor
Author
|
Sure, I can take another look at #449 sometime soon. FWIW, I haven't heard anything about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I briefly attempted to port usage of
impover in #449, but it turned out to be nontrivial.In the future you'll want to either finish the port, or restrict python versions to whenever
impwill be removed.